[Issue 583] Use DateValue objects for "date" values.

http://codereview.appspot.com/6457089/

Author: rmistry

google-http-client/src/main/java/com/google/api/client/util/DateTime.java

@@ -81,6 +81,21 @@ public DateTime(boolean dateOnly, long value, Integer tzShift) {
     this.tzShift = tzShift;
   }
 
+  /**
+   * Instantiates {@link DateTime} from an <a href='http://tools.ietf.org/html/rfc3339'>RFC 3339</a>
+   * date/time value.
+   *
+   * @since 1.11
+   */
+  public DateTime(String value) {
+    // TODO(rmistry): Move the implementation of parseRfc3339 into this constructor. Implementation
+    // of parseRfc3339 can then do "return new DateTime(str);".
+    DateTime dateTime = parseRfc3339(value);
+    this.dateOnly = dateTime.dateOnly;
+    this.value = dateTime.value;
+    this.tzShift = dateTime.tzShift;
+  }
+
   /**
    * Returns the date/time value expressed as the number of milliseconds since the Unix epoch.
    *

google-http-client/src/test/java/com/google/api/client/util/DateTimeTest.java

@@ -46,7 +46,7 @@ public void testEquals() {
         "Check not equal with Date.", new DateTime(1234567890L).equals(new Date(9876543210L)));
   }
 
-  public void testParseDateTime() {
+  public void testParseRfc3339() {
     expectExceptionForParseRfc3339("");
     expectExceptionForParseRfc3339("abc");
     DateTime value = DateTime.parseRfc3339("2007-06-01");
@@ -55,6 +55,13 @@ public void testParseDateTime() {
     assertFalse(value.isDateOnly());
     value = DateTime.parseRfc3339("2007-06-01T10:11:30Z");
     assertEquals(0, value.getValue() % 100);
+
+    value = new DateTime("2007-06-01");
+    assertTrue(value.isDateOnly());
+    value = new DateTime("2007-06-01T10:11:30.057");
+    assertFalse(value.isDateOnly());
+    value = new DateTime("2007-06-01T10:11:30Z");
+    assertEquals(0, value.getValue() % 100);
   }
 
   private void expectExceptionForParseRfc3339(String input) {