Skip to content

Remove deprecated setMethods #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 21, 2021
Merged

Remove deprecated setMethods #9

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
367152e
Ignore vscode
dafeder Aug 20, 2021
9d31c4d
Switch deprecated setMethods to onlyMethods
dafeder Aug 20, 2021
12abe3b
Update phpunit.xml schema
dafeder Aug 20, 2021
5197652
Try new image
dafeder Aug 20, 2021
aa0fe39
Trying new thing w/o ddev
dafeder Aug 20, 2021
aeb7608
No Xdebug needed
dafeder Aug 20, 2021
b34784c
Some code style fixes
dafeder Aug 20, 2021
e22b648
Update expected exception method from onlyMethods
dafeder Aug 20, 2021
7cd52dd
Version 2.1
dafeder Aug 20, 2021
5acf28f
Add test for index
dafeder Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add test for index
  • Loading branch information
@dafeder
dafeder committed Aug 20, 2021
commit 5acf28fc4c390c52bfa1822c45e9dbe7db162a33
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ vendor
composer.lock
coverage
.vscode
.phpunit*
1 change: 0 additions & 1 deletion .phpunit.result.cache
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions test/OptionsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,7 @@ public function test()
$this->assertEquals($options->return("multi"), "shalom");
$this->assertEquals($options->return("multi"), "shalom");
$this->assertNull($options->return('not-an-option'));
$options->index(2);
Copy link
Member Author

@dafeder dafeder Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a dumb test, and should have an equivalent over on the ChainTest side that actually tests the functionality.

$this->assertEquals(2, $options->getIndex());
}
}