-
Notifications
You must be signed in to change notification settings - Fork 39
feat: Closed Captions (experimental) #1271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assign `data-testid` attributes to the Call Control Buttons.
- allow for a primary and secondary active state on the button
- remove redundant code and file
when speaker left or right is active on mobile switch to speaker bottom
- show when url is copied
myandrienko
approved these changes
Feb 23, 2024
# Conflicts: # .github/workflows/deploy-react-sample-apps.yml # packages/react-sdk/src/components/CallControls/ToggleAudioButton.tsx # packages/react-sdk/src/components/CallControls/ToggleVideoButton.tsx # packages/react-sdk/src/translations/en.json # sample-apps/react/react-dogfood/components/ActiveCall.tsx # sample-apps/react/react-dogfood/components/MeetingUI.tsx # sample-apps/react/react-dogfood/hooks/useGleap.ts # sample-apps/react/react-dogfood/style/CallControls/CallControls-layout.scss # sample-apps/react/react-dogfood/style/layout.scss
7 tasks
# Conflicts: # packages/client/src/Call.ts # packages/client/src/gen/coordinator/index.ts
oliverlaz
added a commit
that referenced
this pull request
Apr 5, 2024
…1283) Adds API for registering video filters, default plugin based on TensorFlow Lite, and a sample integration in our Demo app. **New APIs:** - `camera.registerFilter(async (mediaStream) => mediaStream)` the core part. It allows you to chain multiple video and audio filters. - `@stream-io/video-filters-web` - a new lib that is responsible for the ML part and WebGL rendering - `BackgroundFiltersProvider` - a component in the React SDK that helps you to manage the applied filters. Our dogfooding app integrates these new APIs and provides the necessary input (background images) and styling. ### Notes Because of our deployment setup, this PR contains the changes done as part of #1271 and #1276 :)
Member
Author
|
I'm closing this stale PR. These changes are already part of our main branch for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds experimental support for Closed Captions.