use the result of handle(attribute:) to set shouldShowIssueOnItemSelection

Natalia Harateh · Natalia Harateh · commit b79d0aa52436 · 2019-06-02T15:43:24.000-04:00
diff --git a/Classes/Issues/Referenced/IssueReferencedSectionController.swift b/Classes/Issues/Referenced/IssueReferencedSectionController.swift
@@ -48,12 +48,10 @@ final class IssueReferencedSectionController: ListGenericSectionController<Issue
     // MARK: MarkdownStyledTextViewDelegate
 
     func didTap(cell: MarkdownStyledTextView, attribute: DetectedMarkdownAttribute) {
-        if case let .username(username) = attribute {
-            shouldShowIssueOnItemSelection = false
-            viewController?.presentProfile(login: username)
-        } else {
-            viewController?.didTap(cell: cell, attribute: attribute)
+        guard let viewController = viewController else {
+            return
         }
+        shouldShowIssueOnItemSelection = !viewController.handle(attribute: attribute)
     }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -48,12 +48,10 @@ final class IssueReferencedSectionController: ListGenericSectionController<Issue`
`48`	`48`	`// MARK: MarkdownStyledTextViewDelegate`
`49`	`49`
`50`	`50`	`func didTap(cell: MarkdownStyledTextView, attribute: DetectedMarkdownAttribute) {`
`51`		`- if case let .username(username) = attribute {`
`52`		`- shouldShowIssueOnItemSelection = false`
`53`		`- viewController?.presentProfile(login: username)`
`54`		`- } else {`
`55`		`- viewController?.didTap(cell: cell, attribute: attribute)`
	`51`	`+ guard let viewController = viewController else {`
	`52`	`+ return`
`56`	`53`	`}`
	`54`	`+ shouldShowIssueOnItemSelection = !viewController.handle(attribute: attribute)`
`57`	`55`	`}`
`58`	`56`
`59`	`57`	`}`