[kms] fix flaky test #3268
[kms] fix flaky test #3268
Conversation
googlebot
added
the
cla: yes
kms/api-client/snippets_test.py
Outdated
| self.symId) | ||
| except Aborted: | ||
| # aborted by backend. Try again | ||
| try_number += 1 |
There was a problem hiding this comment.
Maybe you want to use @eventually_consistent.call?
An example commit:
c6254e4
There was a problem hiding this comment.
+1 to using eventually consistent if you can
There was a problem hiding this comment.
I didn't know about @eventually_consistent, that's much cleaner!
kms/api-client/snippets_test.py
Outdated
| self.symId) | ||
| except Aborted: | ||
| # aborted by backend. Try again | ||
| try_number += 1 |
There was a problem hiding this comment.
+1 to using eventually consistent if you can
| if b.role == self.role and self.member in b.members: | ||
| found = True | ||
| assert found | ||
| eventually_consistent.call(check_policy, |
There was a problem hiding this comment.
Unfortunately the decorator form doesn't work with the current 0.0.15 release.
See: GoogleCloudPlatform/python-repo-tools#25
I'm trying to make a new release of the above module.
I'm fine with the current form :)
|
@dansanche Sorry for "hot" repo issue ;) I needed to rebase multiple times, but it's good to see the tests are more stable :) |
fixes #2970
I added exponential backoff to the policy test, as recommended by the error message