Skip to content

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Apr 27, 2020

fixes #3554
fixes #3555

It might fix the above issues.

@tmatsuo tmatsuo requested a review from a team as a code owner April 27, 2020 21:49
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2020
@tmatsuo tmatsuo requested a review from daniel-sanche April 27, 2020 21:54
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Apr 28, 2020

The test failure is about quota per projects. We'll need to use multiple project for mitigate that.

google.api_core.exceptions.ResourceExhausted: 429 Quota exceeded for quota metric 'Write requests' and limit 'Write requests per minute' of service 'cloudkms.googleapis.com' for consumer 'project_number:1012616486416'.

I'm going to rebuild and merge.

@tmatsuo tmatsuo merged commit d56abf2 into GoogleCloudPlatform:master Apr 28, 2020
@tmatsuo tmatsuo deleted the fix-kms branch April 28, 2020 00:31
busunkim96 pushed a commit to googleapis/python-kms that referenced this pull request Jun 4, 2020
rsamborski pushed a commit that referenced this pull request Nov 8, 2022
rsamborski pushed a commit that referenced this pull request Nov 11, 2022
rsamborski pushed a commit that referenced this pull request Nov 14, 2022
dandhlee pushed a commit that referenced this pull request Nov 14, 2022
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
4 participants