Skip to content

Commit 5b409ad

Browse files
committed
update to version 12.13.6
1 parent 8c4c132 commit 5b409ad

File tree

13 files changed

+25
-7
lines changed

13 files changed

+25
-7
lines changed

HISTORY.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
.. :changelog:
22
33
Release History
4+
12.13.6(2019-10-12)
5+
+++++++++++++++++++++++++
6+
* Mapped the Experiment Type column to ExperimentType via BulkExperiment.
7+
* Updated Bing Ads API version 12 and 13 service proxies to reflect recent interface changes. For more information please see the Bing Ads API Release Notes: https://docs.microsoft.com/en-us/advertising/guides/release-notes.
8+
49
12.13.5(2019-09-12)
510
+++++++++++++++++++++++++
611
* Map the Bid Adjustment column to a BidMultiplier via BulkAdGroupProductPartition.

bingads/manifest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import sys
2-
VERSION = '12.13.5'
2+
VERSION = '12.13.6'
33
BULK_FORMAT_VERSION_5 = '5.0'
44
BULK_FORMAT_VERSION_6 = '6.0'
55
WORKING_NAME = 'BingAdsSDKPython'

bingads/service_client.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,7 @@ def service_url(self):
104104
key = (self._service, self._environment)
105105
service_info_dict = ServiceClient._get_service_info_dict(self._version)
106106
if key not in service_info_dict:
107-
raise ValueError(str.format('Cannot find version: [v{0}] service: [{1}] under environment: [{2}]. \
108-
Please notice that campaign management, bulk, ad intelligence and optimizer services were deprecated in v9',
107+
raise ValueError(str.format('Cannot find version: [v{0}] service: [{1}] under environment: [{2}].',
109108
self._version, self._input_service, self._input_environment))
110109
return service_info_dict[(self._service, self._environment)].url
111110

bingads/v12/bulk/entities/bulk_experiment.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,11 @@ def experiment(self, experiment):
7878
field_to_csv=lambda c: bulk_str(c.experiment.ExperimentCampaignId),
7979
csv_to_field=lambda c, v: setattr(c.experiment, 'ExperimentCampaignId', int(v) if v else None)
8080
),
81+
_SimpleBulkMapping(
82+
header=_StringTable.ExperimentType,
83+
field_to_csv=lambda c: c.experiment.ExperimentType,
84+
csv_to_field=lambda c, v: setattr(c.experiment, 'ExperimentType', v)
85+
)
8186
]
8287

8388
def process_mappings_from_row_values(self, row_values):

bingads/v12/internal/bulk/csv_headers.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,7 @@ class _CsvHeaders:
173173
_StringTable.BaseCampaignId,
174174
_StringTable.ExperimentCampaignId,
175175
_StringTable.ExperimentId,
176+
_StringTable.ExperimentType,
176177

177178
#CoOp
178179
_StringTable.BidOption,

bingads/v12/internal/bulk/string_table.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ class _StringTable:
1616
BaseCampaignId = "Base Campaign Id"
1717
ExperimentCampaignId = "Experiment Campaign Id"
1818
ExperimentId = "Experiment Id"
19+
ExperimentType = "Experiment Type"
1920
BudgetId = "Budget Id"
2021
AdGroup = "Ad Group"
2122
Keyword = "Keyword"

bingads/v12/proxies/campaign_management_service.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10486,7 +10486,7 @@
1048610486
</wsdl:binding>
1048710487
<wsdl:service name="CampaignManagementService">
1048810488
<wsdl:port name="BasicHttpBinding_ICampaignManagementService" binding="tns:BasicHttpBinding_ICampaignManagementService">
10489-
<soap:address location="https://campaign.api.sandbox.bingads.microsoft.com/Api/Advertiser/CampaignManagement/V12/CampaignManagementService.svc" />
10489+
<soap:address location="https://campaign.api.sandbox.bingads.microsoft.com/Api/Advertiser/CampaignManagement/v12/CampaignManagementService.svc" />
1049010490
</wsdl:port>
1049110491
</wsdl:service>
1049210492
</wsdl:definitions>

bingads/v13/bulk/entities/bulk_ads.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ def ad(self, ad):
163163
_SimpleBulkMapping(
164164
header=_StringTable.FinalUrlSuffix,
165165
field_to_csv=lambda c: bulk_optional_str(c.ad.FinalUrlSuffix, c.ad.Id),
166-
csv_to_field=lambda c, v: setattr(c.ad, 'FinalUrlSuffix', v)
166+
csv_to_field=lambda c, v: setattr(c.ad, 'FinalUrlSuffix', v if v else None)
167167
)
168168
]
169169

bingads/v13/bulk/entities/bulk_experiment.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,11 @@ def experiment(self, experiment):
7878
field_to_csv=lambda c: bulk_str(c.experiment.ExperimentCampaignId),
7979
csv_to_field=lambda c, v: setattr(c.experiment, 'ExperimentCampaignId', int(v) if v else None)
8080
),
81+
_SimpleBulkMapping(
82+
header=_StringTable.ExperimentType,
83+
field_to_csv=lambda c: c.experiment.ExperimentType,
84+
csv_to_field=lambda c, v: setattr(c.experiment, 'ExperimentType', v)
85+
),
8186
]
8287

8388
def process_mappings_from_row_values(self, row_values):

bingads/v13/bulk/entities/bulk_keyword.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ def bid_suggestions(self):
262262
_SimpleBulkMapping(
263263
header=_StringTable.FinalUrlSuffix,
264264
field_to_csv=lambda c: bulk_optional_str(c.keyword.FinalUrlSuffix, c.keyword.Id),
265-
csv_to_field=lambda c, v: setattr(c.keyword, 'FinalUrlSuffix', v)
265+
csv_to_field=lambda c, v: setattr(c.keyword, 'FinalUrlSuffix', v if v else None)
266266
),
267267
]
268268

0 commit comments

Comments
 (0)