Skip to content

Conversation

@trueberryless
Copy link
Contributor

@trueberryless trueberryless commented Jul 27, 2024

Describe the pull request

Adding a new frontmatter property called readingTime, which displays the time it takes to usually read the whole blog post in minutes. #74

How

Adding new readingTime in schema.ts, displaying it in Metadata.astro with the separator not - cause it's much more beautiful.

Screenshots

image

@vercel
Copy link

vercel bot commented Jul 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starlight-blog-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2024 11:01am

Copy link
Owner

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Blocking for now until the implementation is fully discussed and agreed upon in #74.

@trueberryless
Copy link
Contributor Author

This PR will now be closed because the discussion in #74 showed that this is not implemented in an agreed on way and there is a new PR with all the features requested here: #91

@trueberryless trueberryless deleted the readingTime branch November 22, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants