From 464b348ab8b08b28dabb8d5525cd848ee9275df5 Mon Sep 17 00:00:00 2001 From: HyukjinKwon Date: Wed, 12 Aug 2020 17:18:54 +0900 Subject: [PATCH 1/5] Changes in Python --- python/pyspark/sql/tests/test_arrow.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/pyspark/sql/tests/test_arrow.py b/python/pyspark/sql/tests/test_arrow.py index 31287a24265d..982c91ea119a 100644 --- a/python/pyspark/sql/tests/test_arrow.py +++ b/python/pyspark/sql/tests/test_arrow.py @@ -201,7 +201,7 @@ def test_no_partition_frame(self): pdf = df.toPandas() self.assertEqual(len(pdf.columns), 1) self.assertEqual(pdf.columns[0], "field1") - self.assertTrue(False) + self.assertTrue("A") def test_propagates_spark_exception(self): df = self.spark.range(3).toDF("i") From 407ab2cad900007c442d0fa9a1319c3fccb91b65 Mon Sep 17 00:00:00 2001 From: HyukjinKwon Date: Wed, 12 Aug 2020 17:19:51 +0900 Subject: [PATCH 2/5] Change in SQL --- .../spark/unsafe/types/UTF8StringPropertyCheckSuite.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/unsafe/src/test/scala/org/apache/spark/unsafe/types/UTF8StringPropertyCheckSuite.scala b/common/unsafe/src/test/scala/org/apache/spark/unsafe/types/UTF8StringPropertyCheckSuite.scala index 51a54eb07db9..c14c59117ba2 100644 --- a/common/unsafe/src/test/scala/org/apache/spark/unsafe/types/UTF8StringPropertyCheckSuite.scala +++ b/common/unsafe/src/test/scala/org/apache/spark/unsafe/types/UTF8StringPropertyCheckSuite.scala @@ -34,7 +34,7 @@ class UTF8StringPropertyCheckSuite extends AnyFunSuite with ScalaCheckDrivenProp test("toString") { forAll { (s: String) => - assert(toUTF8(s).toString() !== s) + assert(toUTF8(s).toString() === s) } } From 8c526993cff678f086f62882168fe47d60bec3eb Mon Sep 17 00:00:00 2001 From: HyukjinKwon Date: Wed, 12 Aug 2020 17:52:57 +0900 Subject: [PATCH 3/5] Test unsafe instead of sql --- .github/workflows/master.yml | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml index 809ce0133c57..0fbe9042b36f 100644 --- a/.github/workflows/master.yml +++ b/.github/workflows/master.yml @@ -29,18 +29,12 @@ jobs: modules: - >- pyspark-sql + - >- + unsafe # Here, we split Hive and SQL tests into some of slow ones and the rest of them. included-tags: [""] excluded-tags: [""] comment: [""] - include: - # SQL tests - - modules: sql - java: 1.8 - hadoop: hadoop3.2 - hive: hive2.3 - excluded-tags: org.apache.spark.tags.ExtendedSQLTest - comment: "- other tests" env: MODULES_TO_TEST: ${{ matrix.modules }} EXCLUDED_TAGS: ${{ matrix.excluded-tags }} From 18da256484d77a0d8b41e4e805bafba7f07694f4 Mon Sep 17 00:00:00 2001 From: HyukjinKwon Date: Wed, 12 Aug 2020 18:56:11 +0900 Subject: [PATCH 4/5] even exclude pyspark for now --- .github/workflows/master.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml index 0fbe9042b36f..3fa7feeb9bc5 100644 --- a/.github/workflows/master.yml +++ b/.github/workflows/master.yml @@ -27,8 +27,6 @@ jobs: # Kinesis tests depends on external Amazon kinesis service. # Note that the modules below are from sparktestsupport/modules.py. modules: - - >- - pyspark-sql - >- unsafe # Here, we split Hive and SQL tests into some of slow ones and the rest of them. From fad5dd7963bff705a6e6a1f607db67b746fd7894 Mon Sep 17 00:00:00 2001 From: HyukjinKwon Date: Wed, 12 Aug 2020 19:05:23 +0900 Subject: [PATCH 5/5] a --- .github/workflows/test_report.yml | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/.github/workflows/test_report.yml b/.github/workflows/test_report.yml index 13e291d3ca0e..75e7e94d0407 100644 --- a/.github/workflows/test_report.yml +++ b/.github/workflows/test_report.yml @@ -25,19 +25,11 @@ jobs: # Note that the modules below are from sparktestsupport/modules.py. modules: - >- - pyspark-sql + unsafe # Here, we split Hive and SQL tests into some of slow ones and the rest of them. included-tags: [""] excluded-tags: [""] comment: [""] - include: - # SQL tests - - modules: sql - java: 1.8 - hadoop: hadoop3.2 - hive: hive2.3 - excluded-tags: org.apache.spark.tags.ExtendedSQLTest - comment: "- other tests" steps: - uses: haya14busa/action-workflow_run-status@v1 - uses: actions/checkout@v2