Skip to content

[NDTensorsMetalExt] Fix more scalar indexing issues on Metal #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtfishman merged 80 commits into from
Dec 1, 2023
Merged

[NDTensorsMetalExt] Fix more scalar indexing issues on Metal #1264

Changes from 1 commit
Commits
Show all changes
80 commits
Select commit Hold shift + click to select a range
ab39bed
Same issue on Metal and CUDA
kmp5VT Nov 16, 2023
5b63ddd
Replace _gemm! with mul!!
kmp5VT Nov 17, 2023
478131f
Add comment
kmp5VT Nov 17, 2023
1324868
Fix some issues with permutedims in Metal
kmp5VT Nov 17, 2023
526bf4a
Change the default_eltype of NDTensors to Float32 if using Mtl
kmp5VT Nov 17, 2023
4b9be1d
Blocksparse shouldn't use default of Float64. Use NDTensors.default_e…
kmp5VT Nov 17, 2023
5e34f9d
Make sure to revert to original Float64
kmp5VT Nov 17, 2023
3e93f9b
If in Float32 need to adjust atol. Also turn off and on Float32 appro…
kmp5VT Nov 17, 2023
8f9f46c
There is no check when multiplying numbers this might lead to an issu…
kmp5VT Nov 17, 2023
911542d
Format
kmp5VT Nov 17, 2023
fdbdef6
Merge branch 'main' into kmp5/debug/scalar_metal
kmp5VT Nov 17, 2023
cb08934
Merge branch 'main' into kmp5/debug/scalar_metal
kmp5VT Nov 17, 2023
0a2f1ca
Merge branch 'main' into kmp5/debug/scalar_metal
kmp5VT Nov 20, 2023
6780956
Create NDTensorsTestUtils
kmp5VT Nov 20, 2023
1ab3418
Move functions to NDTensorsTestUtils
kmp5VT Nov 20, 2023
2ff61ff
Use NDTensorsTestUtils
kmp5VT Nov 20, 2023
09e95cf
Remove global modification of default_eltype
kmp5VT Nov 20, 2023
cb2bd51
format
kmp5VT Nov 20, 2023
ed10f71
Rename test files test_FILENAME.jl
kmp5VT Nov 20, 2023
c61bc5b
Fix spelling mistake
kmp5VT Nov 21, 2023
6530969
Update test files to create random modules and run in the modules. Al…
kmp5VT Nov 21, 2023
a792341
format
kmp5VT Nov 21, 2023
bb424d7
Create a couple necessary BlockSparseTensor constructors
kmp5VT Nov 21, 2023
b393700
fix dmrg tests
kmp5VT Nov 21, 2023
49b0f7b
Fix metal tests
kmp5VT Nov 21, 2023
c50f431
format
kmp5VT Nov 21, 2023
06a9e47
This is fixed in this pr
kmp5VT Nov 21, 2023
d39f765
fix elt issue in combiner
kmp5VT Nov 21, 2023
cb652b7
format
kmp5VT Nov 21, 2023
c4e7332
use tuple when different types
kmp5VT Nov 21, 2023
dc8b13e
Fix typo
kmp5VT Nov 21, 2023
ef3b4d5
Alphabetize and consistently use LinearAlgebra.
kmp5VT Nov 21, 2023
b22c430
Remove commented code
kmp5VT Nov 21, 2023
e6baedc
Remove comment
kmp5VT Nov 21, 2023
1473da7
remove comma
kmp5VT Nov 21, 2023
40be5aa
Split into two lines
kmp5VT Nov 21, 2023
fc7561f
Need to have module `NDTensors` in path
kmp5VT Nov 22, 2023
25f6d04
Reorder for documentation
kmp5VT Nov 22, 2023
0fbe7b8
Update dense test code
kmp5VT Nov 22, 2023
488aefd
Add better comment
kmp5VT Nov 22, 2023
e7ed450
Fix remaining issues
kmp5VT Nov 22, 2023
87c50e3
format
kmp5VT Nov 22, 2023
4880655
Metal testing now fully functional remove it from extra
kmp5VT Nov 22, 2023
87eca37
Merge remote-tracking branch 'origin/main' into kmp5/debug/scalar_metal
kmp5VT Nov 26, 2023
16b9c74
Move metal back to extras because it cannot be installed properly for…
kmp5VT Nov 26, 2023
7e4839a
use is_supported_eltype function
kmp5VT Nov 26, 2023
2ef4f16
Update NDTensorsCUDAExt example
kmp5VT Nov 27, 2023
e1748be
Remove LinearAlgebra.
kmp5VT Nov 28, 2023
37c0ced
Changes to NDTensorsCUDA example
kmp5VT Nov 28, 2023
663b56e
Remove NDTensors.
kmp5VT Nov 28, 2023
8de246b
Update NDTensors/test/runtests.jl [no-ci]
kmp5VT Nov 28, 2023
e6a68e5
Just bring name into namespace
kmp5VT Nov 28, 2023
edcb6c8
Just use reshape
kmp5VT Nov 28, 2023
246ecd4
Updates to NDTensorsMetal example
kmp5VT Nov 29, 2023
ab237aa
Remove unwrap_type
kmp5VT Nov 29, 2023
0abeb5a
format
kmp5VT Nov 29, 2023
4700b39
calling permutedims(expose(A) ...) can cause a stack overflow.
kmp5VT Nov 29, 2023
ac4f9c1
format
kmp5VT Nov 29, 2023
771403b
Update mul.jl [no-ci]
kmp5VT Nov 29, 2023
c2b39a1
Update mul.jl [no-ci]
kmp5VT Nov 29, 2023
919b041
Update documentation
kmp5VT Nov 29, 2023
d4621f5
Add permutedims for CuArray failing
kmp5VT Nov 29, 2023
98719ed
Merge branch 'kmp5/debug/scalar_metal' of github.com:kmp5VT/ITensors.…
kmp5VT Nov 29, 2023
da62a14
format
kmp5VT Nov 29, 2023
c03accd
Merge branch 'main' into kmp5/debug/scalar_metal
kmp5VT Nov 30, 2023
cda274f
simplifications to NDTensorsCUDA example
kmp5VT Nov 30, 2023
5f29bf4
Allowscalar shouldn't be necessary
kmp5VT Nov 30, 2023
7ce440b
Simplifications to NDTensorsMetal tests
kmp5VT Nov 30, 2023
6dd95d4
spelling
kmp5VT Nov 30, 2023
2498930
formatting
kmp5VT Nov 30, 2023
61562ef
Merge branch 'main' into kmp5/debug/scalar_metal
kmp5VT Nov 30, 2023
8a5a3d7
format
kmp5VT Nov 30, 2023
b56f8a4
grab NDTensors.cpu
kmp5VT Nov 30, 2023
66045ae
Simplify code
kmp5VT Nov 30, 2023
a2d569d
add random module to files its missing
kmp5VT Nov 30, 2023
d85ac43
Move readwrite to `NDTensors/tes/broken`
kmp5VT Dec 1, 2023
ce0caba
Remove @eval module...
kmp5VT Dec 1, 2023
ffbb01c
remove extra end
kmp5VT Dec 1, 2023
bc7c400
Use TupleTools.sort
kmp5VT Dec 1, 2023
3eadb7b
use `TupleTools.sort`
kmp5VT Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
format
  • Loading branch information
@kmp5VT
kmp5VT committed Nov 30, 2023
commit 8a5a3d7fdea665bf6393db92fdcc0f3cfa406547
12 changes: 6 additions & 6 deletions NDTensors/test/arraytensor/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
@eval module $(gensym())
using Test: @testset
@testset "Tensor wrapping AbstractArrays $(f)" for f in [
"array.jl", "blocksparsearray.jl", "diagonalarray.jl"
]
include(f)
end
using Test: @testset
@testset "Tensor wrapping AbstractArrays $(f)" for f in [
"array.jl", "blocksparsearray.jl", "diagonalarray.jl"
]
include(f)
end
end