Respect tns minVersion setting

Author: tsvetie

.gitignore

@@ -29,6 +29,7 @@ build/Release
 # Dependency directories
 node_modules
 jspm_packages
+package-lock.json
 
 # Optional npm cache directory
 .npm

README.md

@@ -25,7 +25,7 @@ installNativeScript.ensureNode()
 * [fixMissingNPMPermissions](#fixmissingnpmpermissions)
 
 ### ensureNode
-The `ensureNode` method checks if node is installed on the machine. In case it cannot detect it, the method downloads a node installer and runs it. You can pass a specific node version to install. In case it is not provided, the method installs version 6.11.4.
+The `ensureNode` method checks if node is installed on the machine. In case it cannot detect it, the method downloads a node installer and runs it. You can pass a specific node version to install. In case it is not provided, the method installs version 8.11.3.
 
 Note: This method changes process.env so that after it succeeds, you can install and detect globally installed npm modules.
 
@@ -37,7 +37,10 @@ installNativeScript.ensureNode();
 ```
 
 ### ensureCLI
-The `ensureCLI` method checks if you have NativeScript CLI installed globally on your machine. In case it cannot detect it, the method installs it globally using npm. You can pass a specific NativeScript CLI version to install. In case it is not provided, the method installs the latest official version.
+The `ensureCLI` method checks if you have NativeScript CLI installed globally on your machine. 
+
+- In case it cannot detect it, the method installs it globally using npm. You can pass a specific NativeScript CLI version to install. In case it is not provided, the method installs the latest official version.
+- In case it detects a version, the method will update it in case you pass a specific minVersion and the current version does not satisfy the requirement. Again, in case a specific version is not provided, the method installs the latest official version.
 
 Usage:
 ```JavaScript

lib/ensure-cli-service.js

@@ -1,3 +1,6 @@
+const _ = require("lodash");
+const semver = require("semver");
+
 module.exports = (helpers, config, sysInfo) => {
     const { logMessage, execSync, stringFormat } = helpers;
     const { getCLICommand, installCLICommand, removeGlobalPackageCommand } = config;
@@ -26,12 +29,6 @@ module.exports = (helpers, config, sysInfo) => {
     };
 
     const installCLI = (cliVersion) => {
-        const cliPath = getDependencyPath();
-
-        if (cliPath) {
-            return;
-        }
-
         const version = cliVersion ? `@${cliVersion}` : "";
         const command = stringFormat(installCLICommand, version);
 
@@ -84,10 +81,29 @@ module.exports = (helpers, config, sysInfo) => {
             });
     };
 
-    const ensureCLI = (cliVersion) => {
+    const ensureCLI = ({ version = "latest", minVersion } = {}) => {
         return findCLI()
+            .then((cliVersion) => {
+                const hasMinRequirement = !_.isNil(minVersion) && !_.isNull(semver.valid(minVersion));
+
+                if (!hasMinRequirement || semver.gte(cliVersion, minVersion)) {
+                    return cliVersion;
+                }
+
+                logMessage(`Found version ${cliVersion} does not satisfy required minVersion ${minVersion}.`);
+
+                installCLI(version);
+
+                return findCLI();
+            })
             .catch(() => {
-                installCLI(cliVersion);
+                const cliPath = getDependencyPath();
+
+                if (cliPath) {
+                    return;
+                }
+
+                installCLI(version);
 
                 return findCLI();
             });

lib/ensure-node-service.js

@@ -77,10 +77,10 @@ module.exports = (helpers, config, sysInfo) => {
             });
     };
 
-    const ensureNode = (nodeVersion = "6.11.4") => {
+    const ensureNode = ({ version = "8.11.3" } = {}) => {
         return findNode()
             .catch(() => {
-                return installNode(nodeVersion)
+                return installNode(version)
                     .then(findNode);
             });
     };

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "install-nativescript",
-  "version": "0.1.3",
+  "version": "0.2.0",
   "description": "Package that helps you install Node.js, npm and nativescript-cli. Works only on Windows and Mac.",
   "main": "index.js",
   "scripts": {
@@ -23,7 +23,8 @@
   "dependencies": {
     "get-shell-vars": "^3.0.0",
     "lodash": "^4.17.4",
-    "nativescript-doctor": "^0.8.0",
+    "nativescript-doctor": "1.2.1",
+    "semver": "5.3.0",
     "sudo-prompt": "^7.0.0",
     "temp": "^0.8.3"
   }