Only set detail if possible

Author: InSyncWithFoo

CHANGELOG.md

@@ -15,6 +15,8 @@ For code changes, see [`CHANGELOG_CODE.md`][_-1].
 
 * Functions, methods and constructors
   can now be autocompleted with parentheses.
+* Auto-import completions now use the source as the supporting detail.
+  Previously the detail was "Auto-import" or a similar localized message.
 
 
 ## [0.4.0] - 2024-05-15

CHANGELOG_CODE.md

@@ -23,11 +23,16 @@ For user-facing changes, see [`CHANGELOG.md`][_-1].
 * [The Qodana Gradle plugin][50-2] and its corresponding action
   [@JetBrains/qodana-action][50-3] are updated to 2024.1.5.
   (85c78a93)
+* Another conditional was added to
+  [`CompletionSupport.createLookupElement`][50-4]
+  to use the source of an auto-import completion as its detail.
+  (4cef2a5d, HEAD)
 
 
   [50-1]: https://github.com/Kotlin/kotlinx-kover
   [50-2]: https://plugins.gradle.org/plugin/org.jetbrains.qodana
   [50-3]: https://github.com/JetBrains/qodana-action
+  [50-4]: https://github.com/InSyncWithFoo/pyright-langserver-for-pycharm/blob/HEAD/src/main/kotlin/com/insyncwithfoo/pyrightls/server/CompletionSupport.kt
 
 
 ## [0.4.0] - 2024-05-15

src/main/kotlin/com/insyncwithfoo/pyrightls/configuration/PathResolvingHint.kt

@@ -36,8 +36,7 @@ internal data class Hint(
 internal fun emptyPathHint() = Hint.info(message("configurations.hint.noPathSpecified"))
 
 
-internal fun invalidPathHint() =
-    Hint.error(message("configurations.hint.invalidPath"))
+internal fun invalidPathHint() = Hint.error(message("configurations.hint.invalidPath"))
 
 
 internal fun executablePathResolvingHint(path: Path) = when {

src/main/kotlin/com/insyncwithfoo/pyrightls/server/CompletionSupport.kt

@@ -35,9 +35,9 @@ private fun CompletionItem.completeWithParentheses() {
 }
 
 
-private fun CompletionItem.useSourceAsDetail() {
+private fun CompletionItem.useSourceAsDetailIfPossible() {
     // https://github.com/microsoft/pyright/blob/0b7860b/packages/pyright-internal/src/languageService/completionProvider.ts#L932-L934
-    detail = labelDetails.description
+    detail = labelDetails?.description ?: ""
 }
 
 
@@ -52,7 +52,7 @@ internal class CompletionSupport(project: Project) : LspCompletionSupport() {
         }
 
         if (item.isAutoImportCompletion) {
-            item.useSourceAsDetail()
+            item.useSourceAsDetailIfPossible()
         }
 
         return super.createLookupElement(parameters, item)