Pride flag watchface

[Aperture32GLaDOS]

Adds a new watch face with the trans flag as a background

Features

• A new watch face, featuring the mlm, trans, bi, and wlw flags
• Bluetooth indicator in the top right
• Long day names

Images

[github-actions]

Build checks have not completed. Possible reasons for this are:

1. The checks need to be approved by a maintainer
2. The branch has conflicts
3. The firmware build has failed

[marigoldfish]

Love it! 🏳️‍⚧️😁 You are a very cool person, I'm going to be using this for a while!

Edit to add: I hope you find $20 on the ground or something similar fortunate and nice happens to you!

[mark9064]

Thanks for the contribution :)

[Aperture32GLaDOS]

Thanks for the quick feedback! I've implemented those changes, hopefully everything's good now

[mark9064]

All looks good to me! You couldn't have made review easier :)

I haven't had the chance to test on hardware yet and am away for now, but I should be able to test within a couple weeks time

[marigoldfish]

I have been using this daily, and I really like it, but I have a few small suggestions:

I adore the "You have mail." for notifications, but I dislike that it overlaps so severely with the battery percentage:

I think it might look better to have "mail." on its own line below, and move "You have" up a little bit so they're both centered vertically in the blue stripe.

(The 90's kid in me really wants it to read "You've got mail," like AOL, but that's not a request for a change, just a nostalgic observation)

My other suggestion is to name the watch face more specifically as "Trans Flag" instead of just "Trans."

Like I said, very very small suggestions. The other 99% of this watchface is grand!

[Aperture32GLaDOS]

I definitely agree with the notification and the name. Fortunately, these are just one-line fixes so it's not that hard to change.

[marigoldfish]

If I can nitpick, I think "Mail" should be lowercase. But this looks really good 😁

[Aperture32GLaDOS]

Good spot, I'll fix that

[marigoldfish]

You are an incredibly awesome and speedy person! Thanks for implementing my suggestions, and so fast! I'll keep testing this daily for a while and let you know if I come across anything else 😁

[marigoldfish]

Hello again, I noticed another little thing after using this watch face for a while.

Usually I keep my watch in 24 hour time, but I had reason to use 12 hour time today, and I noticed that both AM and PM show up as "M."

(I manually set the watch to 2am to get the second picture, I didn't stay up late 😜)

[Aperture32GLaDOS]

I think what's happening here is that the font used for the time doesn't have all the alphabet, if I change the font to something else it seems to work fine:

I've moved the AM/PM display to the day, since that uses a font which has all the alphabet

[marigoldfish]

That's an elegant fix! I like it!

Unfortunately, in addition to praise I also come bearing news of a new bug: it is displaying 24-hour time when I have 12-hour time enabled.

[Aperture32GLaDOS]

Aah, well at least that's an easy fix; it should all be working now

[NeroBurner]

could you update to/rebase onto the latest main branch. The toolchain won't run as the artifacts v3 job was deprecated by GitHub, and that is fixen in the current main branch

[Aperture32GLaDOS]

Yup, should be all good now

[rdub1a4]

Seems like this would wait for side loading. It may not fit the vision of "Only a minimal feature set in the flashed firmware". But, no biggy.

[JustScott]

Seems like this would wait for side loading. It may not fit the vision of "Only a minimal feature set in the flashed firmware". But, no biggy.

I dont understand why this watchface was added to the 1.16.0 milestone so quickly over the various other watchface PRs that have been sitting around for quite a long time?

[mark9064]

Mainly because it doesn't depend on any other PRs and was easy to review

Things get added to the milestone when we want to target including them this cycle. If a PR depends on lots of other refactoring for example, or has outstanding bugs that are taking time to resolve, then it usually won't be queued up for the next cycle until it's ready. InfiniTime generally lacks reviewers though, so what gets queued and what doesn't depends on whether someone's had time to look at it properly

Edit: also you're totally welcome to help with review or express support/interest in PRs in the comments, it helps with prioritising review

[NeroBurner]

coming along nicely. Some code duplication I'd like to get rid of remains

[NeroBurner]

totally optional: could you update the initial PR description to contain updated images for the currently implemented pride flags?

[mark9064]

Looking good! Sounds like my thoughts are pretty similar to @NeroBurner regarding duplication

[NeroBurner]

suggestions to make the build work again

[mark9064]

I think this is good to go!! The flags will never look right in AOD with only 8 colours but I'd like to make sure text at least stays readable. Would you be able to test it quickly? If not I can flash mine

[Aperture32GLaDOS]

Yeah, no worries - I'm flashing it now

[Aperture32GLaDOS]

The time is legible on all of them, but on the trans watch the day and date are invisible - if it's an issue we could change all text to be black

[mark9064]

I don't think it's a big issue - I'll leave whether white or black works better for the trans face to you :)

[Aperture32GLaDOS]

In that case, I'd prefer to leave it as-is, with black for the time and white for everything else

[NeroBurner]

much constness, much wow 🤓

I found a way to have PrideFlagData in cpp file. See comments

[NeroBurner]

just one last const, and then I think we're good to go!

It's been lovely working with you on this MR @Aperture32GLaDOS

[NeroBurner]

all looking good. Thanks for the contribution and your great teamwork! I had fun reviewing and learning on this PR

[Aperture32GLaDOS]

Brilliant! Thanks all for the advice and feedback, it's been very helpful