SSL validation of the IBA certificate should be optional instead of disabled by default

Author: Dennis van Zuijlekom

infoblox.py

@@ -54,21 +54,23 @@ class Infoblox(object):
 	delete_network_extattrs
     """
 
-    def __init__(self, iba_ipaddr, iba_user, iba_password, iba_wapi_version, iba_dns_view, iba_network_view):
+    def __init__(self, iba_ipaddr, iba_user, iba_password, iba_wapi_version, iba_dns_view, iba_network_view, iba_verify_ssl):
 	""" Class initialization method
 	:param iba_ipaddr: IBA IP address of management interface
 	:param iba_user: IBA user name
 	:param iba_password: IBA user password
 	:param iba_wapi_version: IBA WAPI version (example: 1.0)
 	:param iba_dns_view: IBA default view
 	:param iba_network_view: IBA default network view
+        :param iba_verify_ssl: IBA SSL certificate validation (example: False)
 	"""
 	self.iba_host = iba_ipaddr
 	self.iba_user = iba_user
 	self.iba_password = iba_password
 	self.iba_wapi_version = iba_wapi_version
 	self.iba_dns_view = iba_dns_view
 	self.iba_network_view = iba_network_view
+        self.iba_verify_ssl = iba_verify_ssl
 
     def get_next_available_ip(self, network):
 	""" Implements IBA next_available_ip REST API call
@@ -77,13 +79,13 @@ def get_next_available_ip(self, network):
 	"""
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/network?network=' + network + '&network_view=' + self.iba_network_view
 	try:
-	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 	    r_json = r.json()
 	    if r.status_code == 200:
 		if len(r_json) > 0:
 		    net_ref = r_json[0]['_ref']
 		    rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/' + net_ref + '?_function=next_available_ip&num=1'
-		    r = requests.post(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+		    r = requests.post(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 		    r_json = r.json()
 		    if r.status_code == 200:
 			ip_v4 = r_json['ips'][0]
@@ -111,7 +113,7 @@ def create_host_record(self, ip_v4, fqdn):
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/record:host'
 	payload = '{"ipv4addrs": [{"configure_for_dhcp": false,"ipv4addr": "' + ip_v4 + '"}],"name": "' + fqdn + '","view": "' + self.iba_dns_view + '"}'
 	try:
-	    r = requests.post(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False, data=payload)
+	    r = requests.post(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl, data=payload)
 	    r_json = r.json()
 	    if r.status_code == 200 or r.status_code == 201:
 		return
@@ -129,14 +131,14 @@ def delete_host_record(self, fqdn):
 	"""
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/record:host?name=' + fqdn + '&view=' + self.iba_dns_view
 	try:
-	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 	    r_json = r.json()
 	    if r.status_code == 200:
 		if len(r_json) > 0:
 		    host_ref = r_json[0]['_ref']
 		    if host_ref and re.match("record:host\/[^:]+:([^\/]+)\/", host_ref).group(1) == fqdn:
 			rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/' + host_ref
-			r = requests.delete(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+			r = requests.delete(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 			if r.status_code == 200:
 			    return
 			else:
@@ -163,7 +165,7 @@ def add_host_alias(self, host_fqdn, alias_fqdn):
 	"""
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/record:host?name=' + host_fqdn + '&view=' + self.iba_dns_view + '&_return_fields=name,aliases'
 	try:
-	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 	    r_json = r.json()
 	    if r.status_code == 200:
 		if len(r_json) > 0:
@@ -176,7 +178,7 @@ def add_host_alias(self, host_fqdn, alias_fqdn):
 			else:
 			    payload = '{"aliases": ["' + alias_fqdn + '"]}'
 			rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/' + host_ref
-			r = requests.put(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False, data=payload)
+			r = requests.put(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl, data=payload)
 			if r.status_code == 200:
 			    return
 			else:
@@ -203,7 +205,7 @@ def delete_host_alias(self, host_fqdn, alias_fqdn):
 	"""
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/record:host?name=' + host_fqdn + '&view=' + self.iba_dns_view + '&_return_fields=name,aliases'
 	try:
-	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 	    r_json = r.json()
 	    if r.status_code == 200:
 		if len(r_json) > 0:
@@ -214,7 +216,7 @@ def delete_host_alias(self, host_fqdn, alias_fqdn):
 			    aliases.remove(alias_fqdn)
 			    payload = '{"aliases": ' + json.JSONEncoder().encode(aliases) + '}'
 			    rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/' + host_ref
-			    r = requests.put(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False, data=payload)
+			    r = requests.put(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl, data=payload)
 			    if r.status_code == 200:
 				return
 			    else:
@@ -244,7 +246,7 @@ def create_cname_record(self, canonical, name):
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/record:cname'
 	payload = '{"canonical": "' + canonical + '","name": "' + name + '","view": "' + self.iba_dns_view + '"}'
 	try:
-	    r = requests.post(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False, data=payload)
+	    r = requests.post(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl, data=payload)
 	    r_json = r.json()
 	    if r.status_code == 200 or r.status_code == 201:
 		return
@@ -262,14 +264,14 @@ def delete_cname_record(self, fqdn):
 	"""
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/record:cname?name=' + fqdn + '&view=' + self.iba_dns_view
 	try:
-	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 	    r_json = r.json()
 	    if r.status_code == 200:
 		if len(r_json) > 0:
 		    cname_ref = r_json[0]['_ref']
 		    if cname_ref and re.match("record:cname\/[^:]+:([^\/]+)\/", cname_ref).group(1) == fqdn:
 			rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/' + cname_ref
-			r = requests.delete(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+			r = requests.delete(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 			if r.status_code == 200:
 			    return
 			else:
@@ -297,7 +299,7 @@ def create_dhcp_range(self, start_ip_v4, end_ip_v4):
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/range'
 	payload = '{"start_addr": "' + start_ip_v4 + '","end_addr": "' + end_ip_v4 + '"}'
 	try:
-	    r = requests.post(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False, data=payload)
+	    r = requests.post(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl, data=payload)
 	    r_json = r.json()
 	    if r.status_code == 200 or r.status_code == 201:
 		return
@@ -316,14 +318,14 @@ def delete_dhcp_range(self, start_ip_v4, end_ip_v4):
 	"""
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/range?start_addr=' + start_ip_v4 + '?end_addr=' + end_ip_v4 + '&network_view=' + self.iba_network_view
 	try:
-	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 	    r_json = r.json()
 	    if r.status_code == 200:
 		if len(r_json) > 0:
 		    range_ref = r_json[0]['_ref']
 		    if range_ref:
 			rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/' + range_ref
-			r = requests.delete(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+			r = requests.delete(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 			if r.status_code == 200:
 			    return
 			else:
@@ -354,7 +356,7 @@ def get_host(self, fqdn, fields=None):
 	else:
 	    rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/record:host?name=' + fqdn + '&view=' + self.iba_dns_view
 	try:
-	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 	    r_json = r.json()
 	    if r.status_code == 200:
 		if len(r_json) > 0:
@@ -376,7 +378,7 @@ def get_host_by_ip(self, ip_v4):
 	"""
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/ipv4address?ip_address=' + ip_v4 + '&network_view=' + self.iba_network_view
 	try:
-	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 	    r_json = r.json()
 	    if r.status_code == 200:
 		if len(r_json) > 0:
@@ -402,7 +404,7 @@ def get_ip_by_host(self, fqdn):
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/record:host?name=' + fqdn + '&view=' + self.iba_dns_view
 	ipv4addrs = []
 	try:
-	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 	    r_json = r.json()
 	    if r.status_code == 200:
 		if len(r_json) > 0:
@@ -430,7 +432,7 @@ def get_host_extattrs(self, fqdn, attributes=None):
 	"""
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/record:host?name=' + fqdn + '&view=' + self.iba_dns_view + '&_return_fields=name,extensible_attributes'
 	try:
-	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 	    r_json = r.json()
 	    if r.status_code == 200:
 		if len(r_json) > 0:
@@ -465,7 +467,7 @@ def get_network(self, network, fields=None):
 	    fields = 'network,netmask'
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/network?network=' + network + '&network_view=' + self.iba_network_view + '&_return_fields=' + fields
 	try:
-	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 	    r_json = r.json()
 	    if r.status_code == 200:
 		if len(r_json) > 0:
@@ -487,7 +489,7 @@ def get_network_by_ip(self, ip_v4):
 	"""
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/ipv4address?ip_address=' + ip_v4 + '&network_view=' + self.iba_network_view
 	try:
-	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 	    r_json = r.json()
 	    if r.status_code == 200:
 		if len(r_json) > 0:
@@ -519,7 +521,7 @@ def get_network_by_extattrs(self, attributes):
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/network?*' + "&*".join(attributes.split(",")) + '&network_view=' + self.iba_network_view
 	networks = []
 	try:
-	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 	    r_json = r.json()
 	    if r.status_code == 200:
 		if len(r_json) > 0:
@@ -551,7 +553,7 @@ def get_host_by_extattrs(self, attributes):
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/record:host?*' + "&*".join(attributes.split(",")) + '&view=' + self.iba_dns_view
 	hosts = []
 	try:
-	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 	    r_json = r.json()
 	    if r.status_code == 200:
 		if len(r_json) > 0:
@@ -577,7 +579,7 @@ def get_network_extattrs(self, network, attributes=None):
 	"""
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/network?network=' + network + '&network_view=' + self.iba_network_view + '&_return_fields=network,extensible_attributes'
 	try:
-	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 	    r_json = r.json()
 	    if r.status_code == 200:
 		if len(r_json) > 0:
@@ -609,7 +611,7 @@ def update_network_extattrs(self, network, attributes):
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/network?network=' + network + '&network_view=' + self.iba_network_view + '&_return_fields=network,extensible_attributes'
 	extattrs = {}
 	try:
-	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 	    r_json = r.json()
 	    if r.status_code == 200:
 		if len(r_json) > 0:
@@ -620,7 +622,7 @@ def update_network_extattrs(self, network, attributes):
 			    extattrs[attr_name] = attr_value
 			payload = '{"extensible_attributes": ' + json.JSONEncoder().encode(extattrs) + '}'
 			rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/' + network_ref
-			r = requests.put(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False, data=payload)
+			r = requests.put(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl, data=payload)
 			if r.status_code == 200:
 			    return
 			else:
@@ -647,7 +649,7 @@ def delete_network_extattrs(self, network, attributes):
 	"""
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/network?network=' + network + '&network_view=' + self.iba_network_view + '&_return_fields=network,extensible_attributes'
 	try:
-	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 	    r_json = r.json()
 	    if r.status_code == 200:
 		if len(r_json) > 0:
@@ -659,7 +661,7 @@ def delete_network_extattrs(self, network, attributes):
 				del extattrs[attribute]
 			payload = '{"extensible_attributes": ' + json.JSONEncoder().encode(extattrs) + '}'
 			rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/' + network_ref
-			r = requests.put(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False, data=payload)
+			r = requests.put(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl, data=payload)
 			if r.status_code == 200:
 			    return
 			else:
@@ -686,7 +688,7 @@ def create_network(self, network):
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/network'
 	payload = '{"network": "' + network + '","network_view": "' + self.iba_network_view + '"}'
 	try:
-	    r = requests.post(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False, data=payload)
+	    r = requests.post(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl, data=payload)
 	    r_json = r.json()
 	    if r.status_code == 200 or r.status_code == 201:
 		return
@@ -704,14 +706,14 @@ def delete_network(self, network):
 	"""
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/network?network=' + network + '&network_view=' + self.iba_network_view
 	try:
-	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 	    r_json = r.json()
 	    if r.status_code == 200:
 		if len(r_json) > 0:
 		    network_ref = r_json[0]['_ref']
 		    if network_ref:
 			rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/' + network_ref
-			r = requests.delete(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+			r = requests.delete(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 			if r.status_code == 200:
 			    return
 			else:
@@ -738,7 +740,7 @@ def create_networkcontainer(self, networkcontainer):
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/networkcontainer'
 	payload = '{"network": "' + networkcontainer + '","network_view": "' + self.iba_network_view + '"}'
 	try:
-	    r = requests.post(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False, data=payload)
+	    r = requests.post(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl, data=payload)
 	    r_json = r.json()
 	    if r.status_code == 200 or r.status_code == 201:
 		return
@@ -756,14 +758,14 @@ def delete_networkcontainer(self, networkcontainer):
 	"""
 	rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/networkcontainer?network=' + networkcontainer + '&network_view=' + self.iba_network_view
 	try:
-	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+	    r = requests.get(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 	    r_json = r.json()
 	    if r.status_code == 200:
 		if len(r_json) > 0:
 		    network_ref = r_json[0]['_ref']
 		    if network_ref:
 			rest_url = 'https://' + self.iba_host + '/wapi/v' + self.iba_wapi_version + '/' + network_ref
-			r = requests.delete(url=rest_url, auth=(self.iba_user, self.iba_password), verify=False)
+			r = requests.delete(url=rest_url, auth=(self.iba_user, self.iba_password), verify=self.iba_verify_ssl)
 			if r.status_code == 200:
 			    return
 			else: