Add device iterator to ImGui ID stack for device selection pop up in RealSense Viewer#11221
Merged
Nir-Az merged 1 commit intorealsenseai:developmentfrom Jan 10, 2023
martinseilerameria:device_selection_fix_realsense_viewer
Merged
Add device iterator to ImGui ID stack for device selection pop up in RealSense Viewer#11221Nir-Az merged 1 commit intorealsenseai:developmentfrom martinseilerameria:device_selection_fix_realsense_viewer
Nir-Az merged 1 commit intorealsenseai:developmentfrom
martinseilerameria:device_selection_fix_realsense_viewer
Conversation
…e same device name
Collaborator
|
@martinseilerameria Thanks for the fix, |
noacoohen
approved these changes
Jan 10, 2023
Contributor
noacoohen
left a comment
There was a problem hiding this comment.
Thanks a lot, we added your commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in the device selection pop up in RealSense Viewer.
To reproduce:
Problem:
The ID of the ImGui::Selectable is based on the label, which in this case is the device name, which is the same for each camera.
Therefore, there will be an ID conflict and only the first Selectable is working.
Solution:
The problem is solved by adding a unique identifier to the ImGui ID Stack. In the proposed solution this unique identifier is the index of the device in the device_names vector.