Fixing GHA Minimal CMake version check#12266
Merged
Nir-Az merged 1 commit intorealsenseai:developmentfrom Oct 9, 2023
Merged
Conversation
Nir-Az
force-pushed
the
fix_gha_cmake
branch
9 times, most recently
from
191ccbc to
7d39694
Compare
maloel
approved these changes
Oct 9, 2023
Contributor
maloel
left a comment
maloel
left a comment
There was a problem hiding this comment.
Hard to see what changes you made. Next time I recommend moving in one commit and then making changes in another.
I don't quite understand the need for venv, but seems OK.
Collaborator
Author
Yes I agree, next time.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing PR: #12118
Tracked on [LRS-844]