fix PR #12378 missing recordable< recommended-pbs >#12420
Merged
maloel merged 3 commits intorealsenseai:developmentfrom Nov 17, 2023
Merged
fix PR #12378 missing recordable< recommended-pbs >#12420maloel merged 3 commits intorealsenseai:developmentfrom
maloel merged 3 commits intorealsenseai:developmentfrom
Conversation
Nir-Az
approved these changes
Nov 17, 2023
Collaborator
Nir-Az
left a comment
Nir-Az
left a comment
There was a problem hiding this comment.
We do have record and playback UT.
i wonder what is missing for them to catch it
Contributor
Author
You're right, of course. I failed because I wanted it in a software-device. For a live device, we don't need to set the blocks first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #12378 removed the
recommended_processing_blocks_basederivation but I forgot to add back therecordable< recommended_processing_blocks_interface >derivation.This was not caught anywhere, isn't tested, and cannot be caught by compilation since the dependency is only using a
dynamic_castwhich then failed. The result was that the recommended processing blocks were not recorded, so playback didn't have them.I tried adding a test using a software-device but got stuck because there's no public API to add recommended processing blocks to a sensor... I manually tested and made sure it now happens.
Tracked on [LRS-954]