[Viewer] Font size slider#12588
Conversation
| @@ -239,7 +240,7 @@ bool option_model::draw_combobox( notifications_model & model, | |||
|
|
|||
| ImGui::SameLine(); | |||
| if( new_line ) | |||
There was a problem hiding this comment.
The new_line is true by default. Can we remove a check?
There was a problem hiding this comment.
It is a parameter, is it always true?
There was a problem hiding this comment.
Yes, it receives true in the parameters of a function.
We call the function only once without sending it a boolean parameter.
There was a problem hiding this comment.
If it's always try on DQT + RS-Viewer then we can remove it sure
There was a problem hiding this comment.
But on another side in the future, if somebody adds a new call with draw(..., ..., false) it will create unexpected behavior. Sorry, let's leave it as is it now.
| methods.push_back("Camera Timestamp Rate"); | ||
|
|
||
| ImGui::PushItemWidth(r.w - 207); | ||
| ImGui::PushItemWidth(-1.f); |
There was a problem hiding this comment.
What does a width of -1 do?
Looks like the older calculation is related to windows size, don't we need it?
There was a problem hiding this comment.
-1 value set width "to the end available zone"
ImGui::Text("SetNextItemWidth/PushItemWidth(-1)"); ImGui::SameLine(); HelpMarker("Align to right edge"); ImGui::PushItemWidth(-1);
The code sample from imgui_demo.cpp here
There was a problem hiding this comment.
Can we do the same with all combo boxes in the left pane and adjust the border according to the font size?
|
Can we align this 2 sliders to look the same? |
Improved to: |
OK, looks good thanks |
|
Font 19: |
|
|
Font 16: Font 20: |
|
Please rebase before we merge it |
The combo box starts right after his label now and not after the fixed number.
The width of Combo is dynamic according to font size now.
A big_button from the tools panel (3D view) is upgraded to receive float values because the sizes of buttons must be float values due to compatibility with font size.
The Font slider was aligned with the Font Samples
Space increased and dynamic between labels in values in the info Device Details
Tamir91
force-pushed
the
fix_font_changing
branch
from
51f2465 to
e8e38d6
Compare
Rebased |
2 participants
This PR adds an accessibility option to the RS-Viewer + Depth Quality tool settings.
Now the user can control and increase the default application font size.
Tracked on [LRS-979]