Remove memcpy in HWM & command_transfer#12622
Remove memcpy in HWM & command_transfer#12622maloel merged 4 commits intorealsenseai:developmentfrom
Conversation
| std::string err = hwmon_error_string(cmd, err_type); | ||
| LOG_DEBUG(err); | ||
| if (p_response) | ||
| //LOG_DEBUG(err); // too intrusive; may be an expected error |
There was a problem hiding this comment.
You removed the line that initialize err
std::string err = hwmon_error_string(cmd, err_type);
Better to keep as comment or remove both, right?
| { | ||
| *p_response = err_type; | ||
| return std::vector<uint8_t>(); | ||
| return {}; |
There was a problem hiding this comment.
Just to understand, why is this better than before? what happens behind the scene?
There was a problem hiding this comment.
They're exactly the same, except the latter will still work if we change the return type of the function.
|
|
||
| std::vector<uint8_t> send_receive( | ||
| const std::vector<uint8_t>& data, | ||
| uint8_t const * pb, size_t cb, |
There was a problem hiding this comment.
What pb & cp means?
Don't you prefer meaningful names?
There was a problem hiding this comment.
How PB & CP are data and data_size? :)
There was a problem hiding this comment.
It's pretty common Hungarian notation for "pointer to bytes" and "count of bytes".
| size_t receivedCommandDataLength; | ||
| uint8_t receivedOpcode[4]; | ||
|
|
||
| explicit hwmon_cmd(uint8_t cmd_id) |
There was a problem hiding this comment.
Don't we use it?
Python maybe?
There was a problem hiding this comment.
Nope. No longer in use (I removed the only usage).
3 participants
Just some optimization when going over the code.
Also removed disruptive debug messages and expected throws for two options, and the
hwmon_cmdstruct.Instead,
rs2_create_errornow logs these errors.