Skip to content

[Viewer] Accel & Gyro dashboards#12671

Merged
OhadMeir merged 12 commits intorealsenseai:developmentfrom
Tamir91:accel-dashboard
Mar 6, 2024
Merged

[Viewer] Accel & Gyro dashboards#12671
OhadMeir merged 12 commits intorealsenseai:developmentfrom
Tamir91:accel-dashboard

Conversation

@Tamir91
Copy link
Contributor

@Tamir91 Tamir91 commented Feb 15, 2024

Tracked on [LRS-1028]

Acceleration + Gyro Dashboards in the RS Viewer.
Each dashboard may show X, Y, Z, and Norm vector values, and also has the option to increase/decrease showing frame rate.

image

Check boxes completed
The button "add dashboard" appears only when not added dashboard other early.
When a user closes a Viewer without closing the dashboard it will start next time with the same dashboard.
@Tamir91 Tamir91 requested a review from Nir-Az February 15, 2024 12:10
@Nir-Az
Copy link
Collaborator

Nir-Az commented Feb 15, 2024

As discussed, let's add gyro as well

@Nir-Az
Copy link
Collaborator

Nir-Az commented Feb 15, 2024

Tracked on [LRS-1028]

Acceleration Dashboard in the RS Viewer. It shows X, Y, Z, and Norm vector.

image

Can we also minimize the height? no need for such a gap between the radio buttons and the actual dashboard

@Nir-Az Nir-Az requested a review from OhadMeir February 15, 2024 12:53
@Tamir91
Copy link
Contributor Author

Tamir91 commented Feb 15, 2024

Tracked on [LRS-1028]
Acceleration Dashboard in the RS Viewer. It shows X, Y, Z, and Norm vector.
image

Can we also minimize the height? no need for such a gap between the radio buttons and the actual dashboard

After Gyro dashboard I will fix the distance exactly.

@Tamir91
Copy link
Contributor Author

Tamir91 commented Feb 15, 2024

As discussed, let's add gyro as well

Do you prefer to review all of it in one PR?

@Nir-Az
Copy link
Collaborator

Nir-Az commented Feb 15, 2024

As discussed, let's add gyro as well

Do you prefer to review all of it in one PR?

Yes thank you

@Tamir91 Tamir91 changed the title [Viewer] Accel dashboard [Viewer] Accel & Gyro dashboards Feb 28, 2024
Tabs removed from CmakeList
Font scalability improved
Int/float warning fixed
@Tamir91 Tamir91 requested a review from OhadMeir February 28, 2024 09:10
Variables names, Function separating
@Tamir91 Tamir91 requested a review from OhadMeir March 4, 2024 12:38
A slider size is fixed for a small viewer size.
Copy link
Contributor

@OhadMeir OhadMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@OhadMeir OhadMeir merged commit c7c104d into realsenseai:development Mar 6, 2024
Nir-Az added a commit to Nir-Az/librealsense that referenced this pull request Mar 12, 2024
Nir-Az added a commit that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants