Merged
Conversation
Nir-Az
reviewed
Jul 9, 2024
Nir-Az
reviewed
Jul 9, 2024
Nir-Az
reviewed
Jul 9, 2024
OhadMeir
reviewed
Jul 10, 2024
Nir-Az
reviewed
Jul 11, 2024
Nir-Az
reviewed
Jul 11, 2024
| gyro_sensitivity_value = 4.0 | ||
|
|
||
| with test.closure("pipeline - set device"): | ||
| cfg = rs.config() |
Collaborator
There was a problem hiding this comment.
Oh, now I see, why not declare before usage? it's C++ :)
Collaborator
There was a problem hiding this comment.
It's python :)
Same comment but that's OK for now.
In the future, with C++ and python it is better to declare the variable right before usage.
This way if you remove the usage in the future, you will remember to remove the declaration too
Nir-Az
reviewed
Jul 11, 2024
Collaborator
|
Great PR, let's verify the shared/weak ptr think and it's approved from my side. |
Nir-Az
approved these changes
Jul 11, 2024
OhadMeir
reviewed
Jul 11, 2024
OhadMeir
reviewed
Jul 11, 2024
OhadMeir
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding new API to set a device for pipeline, ensuring the pipeline maintains the sensitivity values configured for
this device.
Tracked-by RSDSO-19687