Api connection type#13612
Conversation
|
Hey, let's speak about this PR |
src/dds/rs-dds-device-proxy.cpp
Outdated
| if( j.nested( "product-line" ).get_ex( str ) ) | ||
| register_info( RS2_CAMERA_INFO_PRODUCT_LINE, str ); | ||
| register_info( RS2_CAMERA_INFO_CAMERA_LOCKED, j.nested( "locked" ).default_value( true ) ? "YES" : "NO" ); | ||
| register_info( RS2_CAMERA_INFO_USB_TYPE_DESCRIPTOR, "DDS" ); |
src/ds/d400/d400-device.cpp
Outdated
| if (usb_modality) | ||
| register_info(RS2_CAMERA_INFO_USB_TYPE_DESCRIPTOR, usb_type_str); | ||
| else | ||
| register_info(RS2_CAMERA_INFO_USB_TYPE_DESCRIPTOR, "GMSL"); |
remibettan
force-pushed
the
api_connection_type
branch
from
46fe0d1 to
f760a09
Compare
| if(device_pid == "ABCD")// Specific for D457 | ||
| auto connection_type = dev.get_info(RS2_CAMERA_INFO_CONNECTION_TYPE); | ||
|
|
||
| if (connection_type == std::string("USB") && dev.supports(RS2_CAMERA_INFO_USB_TYPE_DESCRIPTOR)) |
| register_info(RS2_CAMERA_INFO_USB_TYPE_DESCRIPTOR, usb_type_str); | ||
| } | ||
| else | ||
| register_info(RS2_CAMERA_INFO_CONNECTION_TYPE, "GMSL"); |
There was a problem hiding this comment.
Will this list D457 Recovery DFU PID as GMSL as well?
Or we might need to do it elsewhere?
There was a problem hiding this comment.
The behavior for D457 Recovery DFU PID will not be changed.
Today, it seems that no "USB" and no "GMSL" will appear with this device.
Do you need me to check?
| @@ -47,20 +47,26 @@ namespace rs2 | |||
|
|
|||
| // Adjust settings according to USB type | |||
| bool usb3_device = true; | |||
There was a problem hiding this comment.
The exception use case is usb2.
Why not querying if it's USB2 and do
int requested_fps = (usb2_device) ? 15 : 30;
As I understand it, DDS/GMSL/USB3 should set 30 right?
There was a problem hiding this comment.
"As I understand it, DDS/GMSL/USB3 should set 30 right?" this is the current code meaning - I assumed it is right
There was a problem hiding this comment.
The current code works, but I think the logic is more complicated than needed.
You want to check USB2 vs all other
15 vs 30
So better to condition USB2 against all other right?
Currently you have
usb_device
usb3_device..
| if( dev_type == "ABCD" ) // Specific for D457 | ||
| dev_type = "GMSL"; | ||
| dev_type = dev.get_info(RS2_CAMERA_INFO_CONNECTION_TYPE); | ||
| if (dev_type == "USB") |
2 participants
Tracked by: RSDSO-18237