Merged
Conversation
get data size api added to Py, C# and Java wrappers
ev-mp
suggested changes
Aug 18, 2019
Contributor
ev-mp
left a comment
ev-mp
left a comment
There was a problem hiding this comment.
Minor amendments + verify metadata extraction with kernels 4.4 and 4.18 ( with and w/o metadata node)
| return; | ||
| } | ||
|
|
||
| if(_profile.format != 1296715847 && // allow JPEG frames size to be smaller than the uncompressed frame |
Contributor
There was a problem hiding this comment.
Please create a classifier enum for formats with variable bitrates (jpeg/compressed depth) for maintainability. Use hex values in comparisons.
| timestamp = monotonic_to_realtime(timestamp); | ||
|
|
||
| // read metadata from the frame appendix | ||
| acquire_metadata(buf_mgr,fds); |
Contributor
There was a problem hiding this comment.
The metadata extraction should probably be adjusted as previously the pointer was preset to the max frame size
| planes[0] = (byte*)ret.get_data(); | ||
|
|
||
| unpack_yuy2_rgb8(planes, (const byte*)f.get_data(), vf.get_width(), vf.get_height()); | ||
| unpack_yuy2_rgb8(planes, (const byte*)f.get_data(), vf.get_width(), vf.get_height(), vf.get_height() * vf.get_width() * _traget_bpp); |
| void unpack_mjpeg(byte * const dest[], const byte * source, int width, int height, int actual_size) | ||
| { | ||
| //STBIDEF stbi_uc *stbi_load_from_memory(stbi_uc const *buffer, int len, int *x, int *y, int *comp, int req_comp) | ||
| int w, h, bpp; |
Contributor
|
The unresolved task will be handled in a separate PR |
ev-mp
approved these changes
Aug 20, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.