Fixed errors caused by dynamic variable cast#5922
Merged
dorodnic merged 2 commits intorealsenseai:developmentfrom Mar 11, 2020
Merged
Fixed errors caused by dynamic variable cast#5922dorodnic merged 2 commits intorealsenseai:developmentfrom
dorodnic merged 2 commits intorealsenseai:developmentfrom
Conversation
During compilation, Make complained that in initializer list cannot be any implicitly casted values so I've fixed this issue.
ev-mp
approved these changes
Mar 1, 2020
Contributor
ev-mp
left a comment
ev-mp
left a comment
There was a problem hiding this comment.
@militaryCoder , thank you for the contribution,
I'll redirect the PR to development stream as this the policy we practice.
ev-mp
reviewed
Mar 1, 2020
Contributor
ev-mp
left a comment
ev-mp
left a comment
There was a problem hiding this comment.
@militaryCoder , can you rebase to development branch and check whether the PR is still needed ?
Apparently a similar fix has already been accepted (thus the merge conflict).
Thank you
Contributor
Author
|
I see what you mean. |
dorodnic
approved these changes
Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During compilation, Make complained that in initializer list cannot be any
implicitly casted values so I've fixed this issue.