Skip to content

Fix Syncer Memory Leak#6375

Merged
ev-mp merged 1 commit intorealsenseai:developmentfrom
MojamojaK:memory-leak
May 19, 2020
Merged

Fix Syncer Memory Leak#6375
ev-mp merged 1 commit intorealsenseai:developmentfrom
MojamojaK:memory-leak

Conversation

@MojamojaK
Copy link
Contributor

@MojamojaK MojamojaK commented May 9, 2020

@MojamojaK MojamojaK mentioned this pull request May 10, 2020
@dorodnic
Copy link
Contributor

Hi @MojamojaK
Thank you very much for pointing out the mistake.
I was suspecting that the callback was being leaked, but didn't think to check callback registration code :/
I suspect this was an unintentional change that fall through inside much larger refactoring (7fc0f74)

@MojamojaK
Copy link
Contributor Author

Great!
I totally agree with it being an unintentional change.
I have tested the fix on my setup, and it seems to be working fine without any memory leaks solely due to the syncer.

@MojamojaK
Copy link
Contributor Author

Any plans for bumping this?

Copy link
Contributor

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MojamojaK , we'll merge it now.
Thank again for the fix!

@ev-mp ev-mp merged commit c1a5955 into realsenseai:development May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants