Ensure dreps exist prior to delegation #4652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/ensure-dreps-exist-prior-to-delegation
branch
4 times, most recently
from
5055afd to
6e3b413
Compare
lehins
force-pushed
the
lehins/ensure-dreps-exist-prior-to-delegation
branch
2 times, most recently
from
7bc121b to
c98bdd4
Compare
lehins
force-pushed
the
lehins/ensure-dreps-exist-prior-to-delegation
branch
from
c98bdd4 to
a0cac9a
Compare
teodanciu
approved these changes
Oct 4, 2024
Contributor
teodanciu
left a comment
teodanciu
left a comment
There was a problem hiding this comment.
Looks good to me, just a few questions but nothing important - you can safely ignore them.
Soupstraw
reviewed
Oct 7, 2024
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/GovCert.hs
Show resolved
Hide resolved
Soupstraw
reviewed
Oct 7, 2024
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/LedgerTypes/Specs.hs
Show resolved
Hide resolved
Lucsanszky
force-pushed
the
lehins/ensure-dreps-exist-prior-to-delegation
branch
from
aa30e39 to
b0c216f
Compare
Lucsanszky
force-pushed
the
lehins/ensure-dreps-exist-prior-to-delegation
branch
from
b0c216f to
1b13241
Compare
Until now we discarded the delegatee cases. This led to the generation of signals where a delegatee key was already unregistered in the same signal, resulting in a `DelegateeDRepNotRegisteredDELEG` or a `DelegateeStakePoolNotRegisteredDELEG` failure.
This commit can be reverted once the spec is up-to-date with: #4598
Lucsanszky
force-pushed
the
lehins/ensure-dreps-exist-prior-to-delegation
branch
from
1b13241 to
1c97496
Compare
Lucsanszky
reviewed
Oct 8, 2024
Contributor
Lucsanszky
left a comment
Lucsanszky
left a comment
There was a problem hiding this comment.
@teodanciu I marked your remarks as resolved so I can merge. I'll let @lehins to address them.
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4598
Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)