Skip to content

Ensure dreps exist prior to delegation #4652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 8, 2024
Merged

Ensure dreps exist prior to delegation #4652

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
bc5f8d8
Add delegations field to the DRep state
lehins Sep 28, 2024
eb4a25c
Change state for `DELEG` rule to `CertState` from `DState`
lehins Sep 28, 2024
b29751e
Add a new `DelegateeDRepNotRegisteredDELEG` predicate failure
lehins Sep 27, 2024
720f745
Optimize DRep unregistration for case when validation is turned off
lehins Sep 27, 2024
e788510
Prepare CertState to be amendable by delegation logic
lehins Sep 28, 2024
d62e55f
Change state for `GOVCERT` rule to `CertState` from `VState`
lehins Sep 28, 2024
b0e6fe8
Implement cleanup of delegations upon DRep unregistration
lehins Sep 28, 2024
f8ebfa8
Fix couple of tests
lehins Sep 28, 2024
d0f128d
Various non-semantic cleanup
lehins Oct 2, 2024
e36341c
Rename `DelegateeNotRegisteredDELEG` to `DelegateeStakePoolNotRegiste…
lehins Sep 29, 2024
b121543
Implement CertState update with DRep delegations for the intra-era ha…
lehins Oct 3, 2024
4cabe77
Avoid expensive call to `elem` in conformance
lehins Oct 3, 2024
ab542ac
Disable CERTS minitrace conformance tests
lehins Oct 4, 2024
8426fb5
Generate delegs that exist in UMap for dstateSpec
Lucsanszky Oct 5, 2024
5b7714c
Fix `txCertKey` to check for delegatee key as well
Lucsanszky Oct 7, 2024
1c97496
TEMP - Stop generating `UnRegDRep` GovCert cases
Lucsanszky Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid expensive call to elem in conformance
  • Loading branch information
@lehins @Lucsanszky
lehins authored and Lucsanszky committed Oct 8, 2024
commit 4cabe7785b11ceb4ee4e439e4040e33b6f5411b7
7 changes: 4 additions & 3 deletions ...rdano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/ExecSpecRule/Conway/Certs.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@
{-# LANGUAGE FlexibleContexts #-}
{-# LANGUAGE FlexibleInstances #-}
{-# LANGUAGE MultiParamTypeClasses #-}
{-# LANGUAGE RecordWildCards #-}
{-# LANGUAGE ScopedTypeVariables #-}
{-# LANGUAGE TypeApplications #-}
{-# LANGUAGE TypeFamilies #-}
{-# LANGUAGE TypeOperators #-}
{-# LANGUAGE UndecidableInstances #-}
{-# OPTIONS_GHC -Wno-orphans #-}

Expand All @@ -20,6 +18,7 @@ import Data.Bifunctor (first)
import qualified Data.List.NonEmpty as NE
import qualified Data.Map.Strict as Map
import Data.Sequence (Seq)
import qualified Data.Set as Set
import qualified Data.Text as T
import qualified Lib as Agda
import Test.Cardano.Ledger.Conformance
Expand Down Expand Up @@ -72,7 +71,9 @@ instance
fixRewards (Agda.MkHSSet creds) x =
x {Agda.dState = (Agda.dState x) {Agda.dsRewards = zeroRewards (Agda.dsRewards (Agda.dState x))}}
where
zeroRewards (Agda.MkHSMap pairs) = Agda.MkHSMap (map (\(c, r) -> if elem c creds then (c, 0) else (c, r)) pairs)
credsSet = Set.fromList creds
zeroRewards (Agda.MkHSMap pairs) =
Agda.MkHSMap (map (\(c, r) -> if c `Set.member` credsSet then (c, 0) else (c, r)) pairs)
_ -> checkConformance @"CERTS" @Conway @fn ctx env st sig implResTest agdaResTest

nameCerts :: Seq (ConwayTxCert Conway) -> String
Expand Down