Skip to content

Conversation

@crocodile-dentist
Copy link
Contributor

@crocodile-dentist crocodile-dentist commented Feb 7, 2025

Description

  • Properly handle SyncTargetOfActivePeers from configuration.
  • Verify at node startup if peer selection targets are valid or stop
  • Update peer selection trace tags

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@crocodile-dentist crocodile-dentist self-assigned this Feb 7, 2025
@crocodile-dentist crocodile-dentist requested a review from a team as a code owner February 7, 2025 12:16
@crocodile-dentist
Copy link
Contributor Author

Closing in lieu of #6111

@crocodile-dentist crocodile-dentist deleted the mwojtowicz/genesis-outbound-to-non-big-peers branch February 12, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants