Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
151 commits
Select commit Hold shift + click to select a range
e8cbc9d
Add docker compose
alquerci Sep 11, 2021
6b82513
Merge pull request #262 from alquerci/add-docker-compose
thePanz Nov 25, 2022
32b2a4b
Use GitHub actions for Continuous Integration tests
thePanz Nov 25, 2022
21b7381
Fix test for /bin/ls file mimetype guessing, using application/x-pie-…
thePanz Nov 25, 2022
d0e631d
Merge pull request #268 from FriendsOfSymfony1/switch-to-github-actions
thePanz Nov 25, 2022
245c7cc
PHP 8.1 > internal_method_return_types
Tybaze May 19, 2022
6401fcc
PHP 8.1 > Serializable Phase Out
Tybaze May 19, 2022
029b0e7
PHP 8.0 & 8.1 > Deprecated of null to non-nullable internal function …
Tybaze May 23, 2022
dcb1ce3
PHP 8.1 > strftime deprecated.
Tybaze May 23, 2022
8450b13
PHP 8.1 > Unit Test
Tybaze Jun 9, 2022
9cb7fb4
Fix lime message: "An uncaught exception has been thrown" do not have…
Tybaze Jun 9, 2022
25a5e71
PHP 8.1 > uasort(): Returning bool from comparison function is deprec…
Tybaze Jun 9, 2022
09fc710
Fix ValueError: DOMDocument::loadHTML(): Argument #1 ($source) must n…
Tybaze Jun 9, 2022
df2ec65
PHP 8.0 > fread()/count() behavior
Tybaze Jun 9, 2022
42112ab
Fix Declaration of sfPearRestTest::downloadHttp($url, $lastmodified =…
Tybaze Jun 9, 2022
29ab2a7
PHP 8.0 > mktime update
Tybaze Jun 9, 2022
12f7b4c
Fix sfWebResponse->getContentType() return a string not an array
Tybaze Jun 10, 2022
cae793e
Fix sfDoctrineTester, string cannot be accessed as array
Tybaze Jun 10, 2022
7341b43
PHP 8.0 > Fix is_numeric behavior with trailing empty char
Tybaze Jun 10, 2022
b191cb8
PHP 8.0 > String to Number Comparison.
Tybaze Jun 10, 2022
956cb1a
PHP 8.1 > Change support to PHP 8.1
Tybaze May 23, 2022
b0cb92e
Fix UnitTest application/x-sharedlib
Tybaze Jun 10, 2022
bb22141
PHP 8.1 > mysqli_report revert to off
Tybaze Jun 10, 2022
d0d0d12
Refactor code and apply Coding Style fixes
Tybaze Jul 7, 2022
01fadb9
PHP 8.1 > Better MYSQLI_REPORT_OFF implementations for php8.1 compat
Tybaze Aug 2, 2022
3bb8339
PHP 8.1 > remove full_path from uploads added on PHP v8.1
mentalstring Aug 12, 2022
7798328
Fix use of null on string parameter on multiple classes
mentalstring Aug 12, 2022
1e9b188
Github Actions: enable testing on PHP v8.0 and v8.1 (for PRs too)
thePanz Nov 25, 2022
071b8bf
Merge pull request #266 from Tybaze/compat_php8.1
thePanz Nov 25, 2022
fa161a1
test environment for php 8.2
thirsch Dec 13, 2022
f6d779c
PHP 8.2 > Using ${var} in strings is deprecated, use {$var} instead.
thirsch Dec 13, 2022
d89618f
PHP 8.2 > Creation of dynamic property Class::$property is deprecated
thirsch Dec 13, 2022
89c24cf
PHP 8.0 > Uncaught ArgumentCountError: Too few arguments to function
thirsch Dec 13, 2022
754c940
PHP 8.0 > Trying to access array offset on value of type bool
thirsch Dec 13, 2022
13bfee2
PHP 8.0 > Passing null to parameter #1 ($haystack) of type string is …
thirsch Dec 13, 2022
6f50a31
Merge pull request #274 from vemaeg/feature/php-8.2-changes
thePanz Jan 9, 2023
5d94af7
set symfony version to 1.5.15-dev
thirsch Dec 13, 2022
7ad07e0
Update(version) Set symfony version to 1.5.15-dev
thePanz Jan 9, 2023
4820ada
PHP 8.0 > Class name must be a valid object or a string in case the c…
thirsch Dec 13, 2022
c55d53c
PHP 8.0 > Fix undefined array key
thirsch Dec 13, 2022
8b81a56
PHP 8.1 > Fix some more null on string parameter
thirsch Dec 13, 2022
9bba8c5
Merge pull request #272 from vemaeg/feature/more-php-8.1-fixes
thePanz Jan 10, 2023
e432434
Prepared release 1.5.15
thirsch Jan 10, 2023
a72247f
Merge pull request #275 from vemaeg/feature/release-preparations
thePanz Jan 12, 2023
9945f3f
Add(changelog) Add v1.5.15 release date to Changelog file
thePanz Jan 12, 2023
31d2c60
Add(versioning) Add v1.5.16-dev as next release
thePanz Jan 12, 2023
2c5a4d6
Fix(deprecations) Fix deprecations in sfMessageSource_Aggregate (#277)
thePanz Jan 13, 2023
ffbbce6
Add(linting) Add code linting to GitHub workflow, use php-cs-fixer
connorhu Jan 10, 2023
2cbd557
Fix(php-cs) Fix php-cs styles according to configuration
thePanz Feb 20, 2023
dc824de
Add(gitattributes) Add .gitattributes to repository
thePanz Feb 22, 2023
abdecd7
imported upstream php-cs-fixer configuration
akhumphrey Sep 20, 2023
44c6bc6
initial pass of php-cs-fixer
akhumphrey Sep 20, 2023
1bfa5f3
updated config
akhumphrey Sep 21, 2023
0d59d3e
updated config
akhumphrey Sep 21, 2023
72c0635
updated config
akhumphrey Sep 21, 2023
472854c
updated config
akhumphrey Sep 21, 2023
3fce81d
Merged remote tracking branch 'upstream/master' into integration
akhumphrey Sep 21, 2023
96d2848
imported routing fixes from `master`
akhumphrey Oct 10, 2023
ebb5e32
Merged branch 'master' into integration
akhumphrey Oct 10, 2023
57ca872
removed `7.4` and `8.0` test targets
akhumphrey Oct 10, 2023
a5cfe0d
fixed `long_to_shorthand_operator` warnings
akhumphrey Oct 10, 2023
aaf2729
temporarily disabled testing
akhumphrey Oct 15, 2023
3057041
removed route caching
akhumphrey Nov 8, 2023
c142352
fixed coding standards issues
akhumphrey Nov 8, 2023
3303581
re-fixed more coding standards issues
akhumphrey Nov 8, 2023
3c59273
Fix: avoid creating dynamic property $options in sfViewCacheManager (…
vimar Nov 17, 2023
ef9f881
Update(github) Update github workflows, include cache for composer in…
thePanz Nov 16, 2023
2826410
Fix(php-cs-fixer) Fix php-cs-fixer warnings, according to new checks
thePanz Nov 17, 2023
8ba3ff2
add php8.3
connorhu Dec 15, 2023
2a68033
Fix(php-cs-fix) fix php-cs-fix single_space_around_construct warning
connorhu Dec 16, 2023
21c70f1
Fix(php-cs-fixer) Fix php-cs-fixer to v3.45 and apply code fixes
thePanz Dec 30, 2023
1fe8979
Fix(deprecation) preg_match_all requires string parameter (#298)
iricketson Dec 30, 2023
d9e2763
Merged remote tracking branch 'upstream/master' into integration
akhumphrey Jan 3, 2024
be784fc
Fix APC cache tests
mentalstring Jan 23, 2022
1d14219
Add APCu support
mentalstring Jan 23, 2022
5615daa
Fix sfCacheSessionStorageTest with PHP>=7.2
mentalstring Feb 10, 2022
5837057
Remove test dependency on APC
mentalstring Feb 10, 2022
1446798
Fix deprecation on stropos() usage on sfDebug::shortenFilePath (#299)
iricketson Jan 3, 2024
57758f5
Fix strpos() deprecation on sfCacheSessionStorage check for cookie
thePanz Jan 3, 2024
d1dc877
Fix setrawcookie() deprecation on null parameter (#304)
thePanz Jan 3, 2024
6edd425
Fix str_replace() deprecated null parameter on sfNumberFormat
thePanz Jan 3, 2024
806ce84
Declare $params var
iricketson Jan 11, 2024
d60c2c1
Replace default with 0
iricketson Jan 11, 2024
d9c21af
Merged remote tracking branch 'upstream' into integration
akhumphrey Jan 11, 2024
64be8ed
removed some automated testing for old php versions
akhumphrey Jan 11, 2024
0a2daf4
updated `php-cs-fixer` config
akhumphrey Jan 11, 2024
d0f559c
Merge pull request #307 from iricketson/fix/sfValidatorIp
connorhu Jan 14, 2024
f19a707
Merge branch 'master' into fix/sfDoctrineFormGenerator
connorhu Jan 14, 2024
abdbd74
Merge pull request #306 from iricketson/fix/sfDoctrineFormGenerator
connorhu Jan 14, 2024
66e79cf
Update README
mentalstring Jan 16, 2024
424ed4d
Fix link to GitHub pipeline badge
thePanz Jan 17, 2024
9d26d67
fix(config) sfCacheConfigHandler: There is no fourth argument. Nice c…
connorhu Jan 13, 2024
b88d698
Fix PHP8.1 sfForm - Unsupported operand types: array + null on sfForm…
Tybaze Feb 14, 2023
2a15114
Merge branch 'master' into fix-link-to-github-pipeline-badge
connorhu Jan 18, 2024
d90dc72
Merge pull request #311 from FriendsOfSymfony1/fix-link-to-github-pip…
connorhu Jan 18, 2024
e6e9f94
fix(phpdoc) remove html code from throws phpdoc. phpstan don't like this
connorhu Jan 14, 2024
6354fd3
fix(phpdoc) remove version tag
connorhu Jan 18, 2024
38e21c2
Merged remote tracking branch 'upstream' into integration
akhumphrey Feb 2, 2024
b167cb9
applied php-cs-fixer
akhumphrey Feb 2, 2024
bfeea0b
added missing properties
akhumphrey Feb 2, 2024
55a02ab
PHP 8.3 deprecated errors fixed (#320)
miamibc Feb 7, 2024
eca1c5a
Update min PHP requirement to v7.4 or v8.1
thePanz Feb 15, 2024
8bc7519
Remove PHP v8.0 from CI workflow
thePanz Feb 15, 2024
81205f6
Updated gh workflow to use latest actions
thirsch Feb 20, 2024
1b79957
Backported display_errors-handling to sf1
thirsch Feb 19, 2024
5d62a2e
Merged remote tracking branch `upstream/master` into integration
akhumphrey Feb 27, 2024
a4c138b
removed duplicate class properties
akhumphrey Feb 27, 2024
edb850f
Set min versions of swiftmailer to 5.4.13 and 6.2.5 and updated swift…
thirsch Feb 27, 2024
146806f
Sync changelog with latest releases (#337)
thePanz Mar 13, 2024
b74c8d7
Remove(legacy): Remove unsupported PHP docker images
thePanz Mar 13, 2024
c40ce1e
Remove(legacy): drop sfAPCCache cache as apc extension does not exist…
thePanz Mar 13, 2024
a810c4d
Fix(docblock): fix typo in check_configuration.php docblock
thePanz Mar 13, 2024
f1df8ba
Update(check-config): use PHP constant for version check on check_con…
thePanz Mar 13, 2024
e47ec1d
Remove(legacy): delete checks for 'magic_quotes_gpc' and 'register_gl…
thePanz Mar 13, 2024
04ec0aa
Remove(legacy): delete EAccelerator cache, the extension is not exist…
thePanz Mar 13, 2024
019e25d
Remove(legacy): drop XCache support, as the extension is not availabl…
thePanz Mar 13, 2024
2b5a586
Remove(legacy): delete check for PHP < 5.2 in tests for mime_content_…
thePanz Mar 13, 2024
4cab155
Remove(legacy): drop PHP v5.3 check for SQLite version match
thePanz Mar 13, 2024
64d9fc0
Remove(legacy): drop PHP v5.4 check and compatibility layer on sfWebR…
thePanz Mar 13, 2024
30a2fc5
Remove(legacy): drop PHP v5.3 check on sfRoute
thePanz Mar 13, 2024
ccbef01
Update: Update php-cs-fixer to v3.51
thePanz Mar 13, 2024
53a2b12
Update: php-cs-fixer, enable short array syntax
thePanz Mar 13, 2024
f0ba28d
Update: move php-cs-fixer cache under .cache folder
thePanz Mar 13, 2024
4d8148a
Update: run php-cs-fixer on PHP v7.4 as min supported version
thePanz Mar 13, 2024
50a898b
Update: GitHub actions to run php-cs-fixer only on relevant changed f…
thePanz Mar 13, 2024
0bd9d59
Hotfix: Add type checking for deserialized data in sfParameterHolder …
Mar 1, 2024
50c946b
Update php-cs-fixer to v3.52
thePanz Mar 19, 2024
c1b411f
Remove(legacy): drop sf*Cache implementations for APC, XCache and EAc…
thePanz Mar 20, 2024
b9aa8ca
Phpstan: fix warnings on sfAPCiCache implementation, add docblocks an…
thePanz Mar 20, 2024
70aa655
Phpstan: fix warnings on sfFileCache and sfMemcache implementation, a…
thePanz Mar 20, 2024
1844457
Phpstan: fix missing sfTask* return statement
thePanz Mar 20, 2024
c2ea16d
[widget] fix return statement missing (#349)
connorhu Mar 21, 2024
ddc1528
[validator] fix return statement missing (#352)
connorhu Mar 21, 2024
d86803d
[view] fix return statement missing on ParamHolder and CacheManager (…
connorhu Mar 21, 2024
7ddc3d1
[task] Fix return statement missing on some tasks (#353)
connorhu Mar 21, 2024
8b68ee8
[util] fix missing return statement and docblock on sfContext class (…
connorhu Mar 21, 2024
772db3c
Merged remote tracking branch 'upstream' into integration
akhumphrey Mar 27, 2024
970a325
applied upstream php-cs-fixer configuration
akhumphrey Mar 27, 2024
b48ebbd
corrected json format
akhumphrey Mar 27, 2024
793e466
use `php8.2` when linting
akhumphrey Mar 27, 2024
4389e44
don't build php8.1
akhumphrey Mar 27, 2024
ade9503
reverted many changes back to upstream equivalents
akhumphrey Mar 27, 2024
44a6f52
removed upstream submodule
akhumphrey Mar 28, 2024
f3d14d0
replaced submodule with our fork
akhumphrey Mar 28, 2024
10afc80
updated tests to match custom functionality
akhumphrey Mar 28, 2024
438b327
only test php82
akhumphrey Mar 28, 2024
fea21bc
corrected number of expected tests
akhumphrey Mar 28, 2024
22cdd1e
only use php8.2 for github actions
akhumphrey Mar 28, 2024
b17808f
explicitly apply `nullable_type_declaration_for_default_null_value`
akhumphrey Mar 28, 2024
dec9025
attributes don't use `\`
akhumphrey Mar 28, 2024
2185c0d
corrected method signatures
akhumphrey Mar 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PHP 8.0 > mktime update
8.0.0 	hour is no longer optional.
8.0.0 	minute, second, month, day and year are nullable now.
  • Loading branch information
Tybaze authored and thePanz committed Nov 25, 2022
commit 29ab2a79aa8e25d1df2a430a86a01f528ff5d730
9 changes: 9 additions & 0 deletions lib/i18n/sfI18N.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,15 @@ public function getTimestampForCulture($dateTime, $culture = null)
list($day, $month, $year) = $this->getDateForCulture($dateTime, null === $culture ? $this->culture : $culture);
list($hour, $minute) = $this->getTimeForCulture($dateTime, null === $culture ? $this->culture : $culture);

// mktime behavior change with php8
// $hour become not nullable
if (!$hour) {
$hour = 0;
}
// Before 8.0, $minutes value to null, was casted as (int)0
if (!$minute) {
$minute = 0;
}
return null === $day ? null : mktime($hour, $minute, 0, $month, $day, $year);
}

Expand Down