Fixed an issue serializing circular references. http://stackoverflow.com/questions/11616630/json-stringify-avoid-typeerror-converting-circular-structure-to-json

Author: niemyjski

src/Utils-spec.ts

@@ -2,14 +2,22 @@
 
 module Exceptionless {
   describe('Utils', () => {
-      it('should parse version from url', () => {
-        expect(Utils.parseVersion('https://code.jquery.com/jquery-2.1.3.js')).toBe('2.1.3');
-        expect(Utils.parseVersion('//maxcdn.bootstrapcdn.com/bootstrap/3.3.4/css/bootstrap.min.css')).toBe('3.3.4');
-        expect(Utils.parseVersion('https://cdnjs.cloudflare.com/ajax/libs/1140/2.0/1140.css')).toBe('2.0');
-        expect(Utils.parseVersion('https://cdnjs.cloudflare.com/ajax/libs/Base64/0.3.0/base64.min.js')).toBe('0.3.0');
-        expect(Utils.parseVersion('https://cdnjs.cloudflare.com/ajax/libs/angular-google-maps/2.1.0-X.10/angular-google-maps.min.js')).toBe('2.1.0-X.10');
-        expect(Utils.parseVersion('https://cdnjs.cloudflare.com/ajax/libs/swagger-ui/2.1.8-M1/swagger-ui.min.js')).toBe('2.1.8-M1');
-        expect(Utils.parseVersion('https://cdnjs.cloudflare.com/BLAH/BLAH.min.js')).toBe(null);
-      });
+    it('should stringify circular reference', () => {
+      var afoo:any = { a: 'foo' };
+      afoo.b = afoo;
+
+      expect(Utils.stringify(afoo)).toBe('{"a":"foo"}');
+      expect(Utils.stringify({ one: afoo, two: afoo })).toBe('{"one":{"a":"foo"}}');
+    });
+
+    it('should parse version from url', () => {
+      expect(Utils.parseVersion('https://code.jquery.com/jquery-2.1.3.js')).toBe('2.1.3');
+      expect(Utils.parseVersion('//maxcdn.bootstrapcdn.com/bootstrap/3.3.4/css/bootstrap.min.css')).toBe('3.3.4');
+      expect(Utils.parseVersion('https://cdnjs.cloudflare.com/ajax/libs/1140/2.0/1140.css')).toBe('2.0');
+      expect(Utils.parseVersion('https://cdnjs.cloudflare.com/ajax/libs/Base64/0.3.0/base64.min.js')).toBe('0.3.0');
+      expect(Utils.parseVersion('https://cdnjs.cloudflare.com/ajax/libs/angular-google-maps/2.1.0-X.10/angular-google-maps.min.js')).toBe('2.1.0-X.10');
+      expect(Utils.parseVersion('https://cdnjs.cloudflare.com/ajax/libs/swagger-ui/2.1.8-M1/swagger-ui.min.js')).toBe('2.1.8-M1');
+      expect(Utils.parseVersion('https://cdnjs.cloudflare.com/BLAH/BLAH.min.js')).toBe(null);
+    });
   });
 }

src/Utils.ts

@@ -79,5 +79,22 @@ module Exceptionless {
     public static randomNumber(): number {
       return Math.floor(Math.random() * 9007199254740992);
     }
+
+    public static stringify(data:any): string {
+      var cache = [];
+
+      return JSON.stringify(data, function(key, value) {
+        if (typeof value === 'object' && value !== null) {
+          if (cache.indexOf(value) !== -1) {
+            // Circular reference found, discard key
+            return;
+          }
+
+          cache.push(value);
+        }
+
+        return value;
+      });
+    }
   }
 }

src/submission/DefaultSubmissionClient.ts

@@ -4,15 +4,15 @@ module Exceptionless {
   export class DefaultSubmissionClient implements ISubmissionClient {
     public submit(events:IEvent[], config:Configuration): Promise<SubmissionResponse> {
       var url = config.serverUrl + '/api/v2/events?access_token=' + encodeURIComponent(config.apiKey);
-      return this.sendRequest('POST', url, JSON.stringify(events)).then(
+      return this.sendRequest('POST', url, Utils.stringify(events)).then(
           xhr => { return new SubmissionResponse(xhr.status, this.getResponseMessage(xhr)); },
           xhr => { return new SubmissionResponse(xhr.status || 500, this.getResponseMessage(xhr)); }
       );
     }
 
     public submitDescription(referenceId:string, description:IUserDescription, config:Configuration): Promise<SubmissionResponse> {
       var url = config.serverUrl + '/api/v2/events/by-ref/' + encodeURIComponent(referenceId) + '/user-description?access_token=' + encodeURIComponent(config.apiKey);
-      return this.sendRequest('POST', url, JSON.stringify(description)).then(
+      return this.sendRequest('POST', url, Utils.stringify(description)).then(
           xhr => { return new SubmissionResponse(xhr.status, this.getResponseMessage(xhr)); },
           xhr => { return new SubmissionResponse(xhr.status || 500, this.getResponseMessage(xhr)); }
       );