Fixed unit tests

Author: niemyjski

packages/core/src/ExceptionlessClient.ts

@@ -217,6 +217,8 @@ export class ExceptionlessClient {
       context.log.info(`Setting last reference id "${ev.reference_id}"`);
       config.services.lastReferenceIdManager.setLast(ev.reference_id);
     }
+
+    return context;
   }
 
   /**

packages/core/src/configuration/Configuration.ts

@@ -48,21 +48,21 @@ export class Configuration {
   public enabled: boolean = true;
 
   public services: {
-    environmentInfoCollector?: IEnvironmentInfoCollector,
-    errorParser?: IErrorParser,
-    lastReferenceIdManager: ILastReferenceIdManager,
-    log: ILog,
-    moduleCollector?: IModuleCollector,
-    requestInfoCollector?: IRequestInfoCollector,
-    submissionClient?: ISubmissionClient,
-    storage: IStorageProvider,
-    queue: IEventQueue
-  } = {
+      environmentInfoCollector?: IEnvironmentInfoCollector,
+      errorParser?: IErrorParser,
+      lastReferenceIdManager: ILastReferenceIdManager,
+      log: ILog,
+      moduleCollector?: IModuleCollector,
+      requestInfoCollector?: IRequestInfoCollector,
+      submissionClient?: ISubmissionClient,
+      storage: IStorageProvider,
+      queue: IEventQueue
+    } = {
       lastReferenceIdManager: new DefaultLastReferenceIdManager(),
       log: new NullLog(),
       storage: new InMemoryStorageProvider(),
       queue: new DefaultEventQueue(this)
-    }
+    };
 
   /**
    * Maximum number of events that should be sent to the server together in a batch. (Defaults to 50)
@@ -117,13 +117,13 @@ export class Configuration {
    */
   private _dataExclusions: string[] = [];
 
-  private _includePrivateInformation: boolean;
-  private _includeUserName: boolean;
-  private _includeMachineName: boolean;
-  private _includeIpAddress: boolean;
-  private _includeCookies: boolean;
-  private _includePostData: boolean;
-  private _includeQueryString: boolean;
+  private _includePrivateInformation: boolean = true;
+  private _includeUserName: boolean = true;
+  private _includeMachineName: boolean = true;
+  private _includeIpAddress: boolean = true;
+  private _includeCookies: boolean = true;
+  private _includePostData: boolean = true;
+  private _includeQueryString: boolean = true;
 
   /**
    * A list of user agent patterns.
@@ -305,7 +305,7 @@ export class Configuration {
    * @param value
    */
   public set includePrivateInformation(value: boolean) {
-    const val = value || false;
+    const val = value === true;
     this._includePrivateInformation = val;
     this._includeUserName = val;
     this._includeMachineName = val;
@@ -330,7 +330,7 @@ export class Configuration {
    * @param value
    */
   public set includeUserName(value: boolean) {
-    this._includeUserName = value || false;
+    this._includeUserName = value === true;
     this.changed();
   }
 
@@ -347,7 +347,7 @@ export class Configuration {
    * @param value
    */
   public set includeMachineName(value: boolean) {
-    this._includeMachineName = value || false;
+    this._includeMachineName = value === true;
     this.changed();
   }
 
@@ -364,7 +364,7 @@ export class Configuration {
    * @param value
    */
   public set includeIpAddress(value: boolean) {
-    this._includeIpAddress = value || false;
+    this._includeIpAddress = value === true;
     this.changed();
   }
 
@@ -383,7 +383,7 @@ export class Configuration {
    * @param value
    */
   public set includeCookies(value: boolean) {
-    this._includeCookies = value || false;
+    this._includeCookies = value === true;
     this.changed();
   }
 
@@ -402,7 +402,7 @@ export class Configuration {
    * @param value
    */
   public set includePostData(value: boolean) {
-    this._includePostData = value || false;
+    this._includePostData = value === true;
     this.changed();
   }
 
@@ -421,7 +421,7 @@ export class Configuration {
    * @param value
    */
   public set includeQueryString(value: boolean) {
-    this._includeQueryString = value || false;
+    this._includeQueryString = value === true;
     this.changed();
   }
 

packages/core/test/ExceptionlessClient.test.ts

@@ -4,26 +4,31 @@ import { KnownEventDataKeys } from "../src/models/Event.js";
 
 describe("ExceptionlessClient", () => {
   test("should use event reference ids", async () => {
+    const error = createException();
+
     const client = new ExceptionlessClient();
     client.config.apiKey = "UNIT_TEST_API_KEY";
-    const { lastReferenceIdManager } = client.config.services;
 
+    const { lastReferenceIdManager } = client.config.services;
     expect(lastReferenceIdManager.getLast()).toBeNull();
 
-    const error = createException();
-    await client.submitException(error);
+    let context = await client.submitException(error);
+    expect(context.event.reference_id).toBeUndefined();
     expect(lastReferenceIdManager.getLast()).toBeNull();
 
     const numberOfPlugins = client.config.plugins.length;
     client.config.useReferenceIds();
     expect(client.config.plugins.length).toBe(numberOfPlugins + 1);
 
-    const context = await client.submitException(error);
-    if (!context.cancelled) {
-      expect(lastReferenceIdManager.getLast()).not.toBeNull();
-    } else {
-      expect(lastReferenceIdManager.getLast()).toBeNull();
-    }
+    context = await client.submitException(error);
+    expect(context.event.reference_id).not.toBeUndefined();
+    const lastReference: string = lastReferenceIdManager.getLast();
+    expect(context.event.reference_id).toBe(lastReference);
+
+    context = await client.submitException(error);
+    expect(context.event.reference_id).not.toBeUndefined();
+    expect(context.event.reference_id).not.toBe(lastReference);
+    expect(context.event.reference_id).toBe(lastReferenceIdManager.getLast());
   });
 
   test("should accept null source", () => {

packages/core/test/plugins/default/ErrorPlugin.test.ts

@@ -50,7 +50,6 @@ describe("ErrorPlugin", () => {
         const additionalData = getAdditionalData(event);
         expect(additionalData).toBeUndefined();
       });
-
     });
 
     test("should add custom properties to additional data", async () => {

packages/core/test/plugins/default/EventPluginTestFixture.ts

@@ -2,8 +2,8 @@ import { ContextData } from "../../../src/plugins/ContextData.js";
 import { EventPluginContext } from "../../../src/plugins/EventPluginContext.js";
 import { IErrorParser } from "../../../src/services/IErrorParser.js";
 import { Event } from "../../../src/models/Event.js";
+import { ExceptionlessClient } from "../../../src/ExceptionlessClient.js";
 
-// TODO: This should use the real object instances and inject the error parser.
 export function createFixture(): { contextData: ContextData, context: EventPluginContext, client: any, event: Event } {
   const errorParser: IErrorParser = {
     parse: (c: EventPluginContext, exception: Error) => Promise.resolve({
@@ -12,15 +12,9 @@ export function createFixture(): { contextData: ContextData, context: EventPlugi
       stack_trace: (exception as any).testStack || null
     })
   };
-  const client: any = {
-    config: {
-      dataExclusions: [],
-      errorParser,
-      log: {
-        info: () => { }
-      }
-    }
-  };
+  const client: ExceptionlessClient = new ExceptionlessClient();
+  client.config.services.errorParser = errorParser;
+
   const event: Event = {
     data: {}
   };

packages/core/test/storage/InMemoryStorage.test.ts

@@ -3,9 +3,12 @@ import { InMemoryStorage } from "../../src/storage/InMemoryStorage.js";
 import { IStorage } from "../../src/storage/IStorage.js";
 import { IStorageItem } from "../../src/storage/IStorageItem.js";
 
-describeStorage("InMemoryStorage", (maxItems = 250) => {
-  return new InMemoryStorage(maxItems);
-});
+describeStorage(
+  "InMemoryStorage",
+  (maxItems = 250) => {
+    return new InMemoryStorage(maxItems);
+  }
+);
 
 export function describeStorage(
   name: string,

packages/node/test/storage/NodeFileStorage.test.ts

@@ -9,15 +9,16 @@ import {
 
 const directory: string = "./test-data";
 const nodeFileStorageFactory = (maxItems?: number): IStorage => {
-  return new NodeFileStorage("test", directory, "ex-", maxItems);
+  return new NodeFileStorage("test", directory, maxItems);
 };
 
 function resetStorageDirectory() {
   rmSync(directory, { recursive: true, force: true });
   mkdirSync(directory);
 }
 
-describeStorage("NodeFileStorage",
+describeStorage(
+  "NodeFileStorage",
   nodeFileStorageFactory,
   resetStorageDirectory,
   resetStorageDirectory,