WIP Browser plugins

Author: niemyjski

.vscode/settings.json

@@ -25,6 +25,7 @@
     "lage",
     "maxcdn",
     "nameof",
+    "ncaught",
     "tsproject",
     "webcompat"
   ],

packages/browser/src/BrowserExceptionlessClient.ts

@@ -59,12 +59,6 @@ export class BrowserExceptionlessClient extends ExceptionlessClient {
   }
 }
 
-//function processUnhandledException(stackTrace: TraceKit.StackTrace, options?: any): void {
-//  const builder = ExceptionlessClient.default.createUnhandledException(new Error(stackTrace.message || (options || {}).status || "Script error"), "onerror");
-//  builder.pluginContextData["@@_TraceKit.StackTrace"] = stackTrace;
-//  builder.submit();
-//}
-
 /*
   TODO: We currently are unable to parse string exceptions.
   function processJQueryAjaxError(event, xhr, settings, error:string): void {
@@ -85,15 +79,10 @@ export class BrowserExceptionlessClient extends ExceptionlessClient {
 //TraceKit.report.subscribe(processUnhandledException);
 //TraceKit.extendToAsynchronousCallbacks();
 
-// window && window.addEventListener && window.addEventListener("beforeunload", function () {
-//   ExceptionlessClient.default.config.queue.process(true);
-// });
 
 // if (typeof $ !== "undefined" && $(document)) {
 //   $(document).ajaxError(processJQueryAjaxError);
 // }
-
-//(Error as any).stackTraceLimit = Infinity;
 //declare var $;
 
 // browser plugin startup method wires up all handlers?

packages/browser/src/plugins/GlobalHandlerPlugin.ts

@@ -1,36 +1,72 @@
 import {
   ExceptionlessClient,
   IEventPlugin,
-  PluginContext
+  PluginContext,
+  nameof
 } from "@exceptionless/core";
 
 export class GlobalHandlerPlugin implements IEventPlugin {
   public priority: number = 100;
   public name: string = "GlobalHandlerPlugin";
 
-  private client: ExceptionlessClient = null;
+  private _client: ExceptionlessClient = null;
 
   public startup(context: PluginContext): Promise<void> {
-    if (this.client) {
+    if (this._client) {
       return;
     }
 
-    this.client = context.client;
+    this._client = context.client;
     Error.stackTraceLimit = Infinity;
 
     // TODO: Discus if we want to unwire this handler in suspend?
     const originalOnError: OnErrorEventHandlerNonNull = globalThis.onerror;
-    globalThis.onerror = (event: Event | string, source?: string, lineno?: number, colno?: number, error?: Error): any => {
-      /*
-      const builder = this.client.createUnhandledException(new Error(stackTrace.message || (options || {}).status || "Script error"), "onerror");
-      builder.pluginContextData["@@_TraceKit.StackTrace"] = stackTrace;
-      void builder.submit(); // TODO: Handle async?
-      */
+    globalThis.onerror = (event: Event | string, source?: string, lineno?: number, colno?: number, error?: Error) => {
+      // TODO: Handle async
+      void this._client.submitUnhandledException(error || this.buildError(event, source, lineno, colno), nameof<Window>("onerror"));
 
       // eslint-disable-next-line prefer-rest-params
       return originalOnError ? originalOnError.apply(this, ...arguments) : false;
     };
 
+    const originalOnunhandledrejection = globalThis.onunhandledrejection;
+    globalThis.onunhandledrejection = (pre: PromiseRejectionEvent) => {
+      let error = pre.reason;
+      try {
+        const reason = (<any>pre).detail?.reason;
+        if (reason) {
+          error = reason;
+        }
+        // eslint-disable-next-line no-empty
+      } catch (ex) { }
+
+      // TODO: Handle async
+      void this._client.submitUnhandledException(error, nameof<Window>("onunhandledrejection"));
+
+      // eslint-disable-next-line prefer-rest-params
+      return originalOnunhandledrejection ? originalOnunhandledrejection.apply(this, ...arguments) : false;
+    };
+
     return Promise.resolve();
   }
+
+  private buildError(event: Event | string, source?: string, lineno?: number, colno?: number): Error {
+    let name: string = "Error";
+    let message: string = Object.prototype.toString.call(event) === '[object ErrorEvent]' ? (<ErrorEvent>event).message : null;
+    if (message) {
+      const errorNameRegex: RegExp = /^(?:[Uu]ncaught (?:exception: )?)?(?:((?:Aggregate|Eval|Internal|Range|Reference|Syntax|Type|URI|)Error): )?(.*)$)/i;
+      const [_, errorName, errorMessage] = errorNameRegex.exec(message);
+      if (errorName) {
+        name = errorName;
+      }
+      if (errorMessage) {
+        message = errorMessage;
+      }
+    }
+
+    const error = new Error(message || "Script error");
+    error.name = name;
+    error.stack = `at ${source || ""}:${!isNaN(lineno) ? lineno : 0}${!isNaN(colno) ? ":" + colno : ""}`;
+    return error;
+  }
 }

packages/browser/src/plugins/LifeCyclePlugin.ts

@@ -0,0 +1,22 @@
+import {
+  ExceptionlessClient,
+  IEventPlugin,
+  PluginContext
+} from "@exceptionless/core";
+
+export class LifeCyclePlugin implements IEventPlugin {
+  public priority: number = 100;
+  public name: string = "LifeCyclePlugin";
+
+  private _client: ExceptionlessClient = null;
+
+  public startup(context: PluginContext): Promise<void> {
+    if (this._client) {
+      return;
+    }
+
+    this._client = context.client;
+    globalThis.addEventListener("beforeunload", async () => await this._client.processQueue());
+    return Promise.resolve();
+  }
+}

packages/core/src/index.ts

@@ -82,4 +82,5 @@ export {
   startsWith,
   stringify,
   toBoolean,
+  nameof
 } from "./Utils.js";