Added the ability to register to window.onerror.

There are some bugs with window.onerror:
stacktracejs/stacktrace.js#117

Author: niemyjski

src/StackTrace.d.ts

@@ -2,7 +2,9 @@
 
 declare module StackTrace {
   interface StackTraceOptions {
-    filter: (stackFrame:StackFrame) => boolean;
+    filter?: (stackFrame:StackFrame) => boolean;
+    sourceCache?: { URL:string };
+    offline?: boolean;
   }
 
   interface StackFrame {

src/example/index.js

@@ -0,0 +1,15 @@
+function getNonexistentData() {
+  /* random comment */ nonexistentArray[arguments[0]]; // second random comment;
+}
+
+function throwDivisionByZero() {
+  return divide(10, 0);
+}
+
+function throwIndexOutOfRange(indexer) {
+  try {
+    getNonexistentData(indexer);
+  } catch (e) {
+    Exceptionless.ExceptionlessClient.default.submitException(e);
+  }
+}

src/example/math.js

@@ -0,0 +1,7 @@
+function divide(numerator, denominator) {
+  if (denominator == 0) {
+    throw( "Division by zero." );
+  }
+
+  return numerator / denominator;
+}

src/exceptionless.ts

@@ -4,7 +4,9 @@
 // TODO: Process Errors
 // TODO: Handle Server Settings
 // TODO: Lock configuration.
-// TODO: Look into using templated strings `${1 + 1}`
+// TODO: Look into using templated strings `${1 + 1}`.
+// TODO: Add plugin for populating module info.
+// TODO: Add plugin for populating defaults.
 
 module Exceptionless {
   export class ExceptionlessClient {
@@ -24,10 +26,15 @@ module Exceptionless {
       this.createException(exception).submit();
     }
 
-    public submitUnhandledException(exception:Error): void {
+    public createUnhandledException(exception:Error): EventBuilder {
       var builder = this.createException(exception);
       builder.pluginContextData.markAsUnhandledError();
-      builder.submit();
+
+      return builder;
+    }
+
+    public submitUnhandledException(exception:Error): void {
+      this.createUnhandledException(exception).submit();
     }
 
     public createFeatureUsage(feature:string): EventBuilder {
@@ -138,6 +145,37 @@ module Exceptionless {
     public getLastReferenceId(): string {
       return this.config.lastReferenceIdManager.getLast();
     }
+
+    public register(): void {
+      var oldOnErrorHandler:any = window.onerror;
+      (<any>window).onerror = (message:string, filename:string, lineno:number, colno:number, error:Error) => {
+        if(error !== null) {
+          this.submitUnhandledException(error);
+        } else {
+          // Only message, filename and lineno work here.
+          var e:IError = { message: message, stack_trace: [{ file_name: filename, line_number: lineno, column: colno }]};
+          this.createUnhandledException(new Error(message)).setMessage(message).setProperty('@error', e).submit();
+        }
+
+        if (oldOnErrorHandler) {
+          try {
+            return oldOnErrorHandler(message, filename, lineno, colno, error);
+          } catch(e) {
+            this.config.log.error('An error occurred while calling previous error handler: ' + e.message);
+          }
+        }
+
+        return false;
+      }
+    }
+
+    private static _instance:ExceptionlessClient = null;
+    public static get default() {
+      if(ExceptionlessClient._instance === null) {
+        ExceptionlessClient._instance = new ExceptionlessClient(null);
+      }
+      return ExceptionlessClient._instance;
+    }
   }
 
   export class Configuration {
@@ -285,13 +323,15 @@ module Exceptionless {
     private _suspendProcessingUntil:Date;
     private _discardQueuedItemsUntil:Date;
     private _processingQueue:boolean = false;
-    private _queueTimer:number = setInterval(() => this.onProcessQueue(), 10000);
+    private _queueTimer:number;
 
     constructor(config:Configuration) {
       this._config = config;
     }
 
     public enqueue(event:IEvent) {
+      this.ensureQueueTimer();
+
       if (this.areQueuedItemsDiscarded()) {
         this._config.log.info('Queue items are currently being discarded. The event will not be queued.');
         return;
@@ -303,6 +343,8 @@ module Exceptionless {
     }
 
     public process() {
+      this.ensureQueueTimer();
+
       if (this._processingQueue) {
         return;
       }
@@ -392,13 +434,19 @@ module Exceptionless {
       }
     }
 
-    private onProcessQueue() {
+    private ensureQueueTimer() : void {
+      if (!this._queueTimer) {
+        this._queueTimer = setInterval(() => this.onProcessQueue(), 10000);
+      }
+    }
+
+    private onProcessQueue(): void {
       if (!this.isQueueProcessingSuspended() && !this._processingQueue) {
         this.process();
       }
     }
 
-    public suspendProcessing(durationInMinutes?:number, discardFutureQueuedItems?:boolean, clearQueue?:boolean) {
+    public suspendProcessing(durationInMinutes?:number, discardFutureQueuedItems?:boolean, clearQueue?:boolean): void {
       if (!durationInMinutes || durationInMinutes <= 0) {
         durationInMinutes = 5;
       }
@@ -420,7 +468,7 @@ module Exceptionless {
       } catch (Exception) { }
     }
 
-    private requeueEvents(events:IEvent[]) {
+    private requeueEvents(events:IEvent[]): void {
       this._config.log.info('Requeuing ' + events.length + ' events.');
 
       for (var index = 0; index < events.length; index++) {
@@ -907,21 +955,6 @@ module Exceptionless {
           return plugin.run(context);
         });
       }, Promise.resolve());
-
-/*
-      for (var index = 0; index < context.client.config.plugins.length; index++) {
-        try {
-          var plugin = context.client.config.plugins[index];
-          plugin.run(context);
-          if (context.cancel) {
-            context.log.info('Event submission cancelled by plugin "' + plugin.name + '": id=' + context.event.reference_id + ' type=' + context.event.type);
-            return;
-          }
-        } catch (e) {
-          context.log.error('An error occurred while running ' + plugin.name + '.run(): ' + e.message);
-        }
-      }
-*/
     }
 
     public static addDefaultPlugins(config:Configuration): void {
@@ -961,23 +994,30 @@ module Exceptionless {
       }
 
       context.event.type = 'error';
+      if (!!context.event.data['@error']) {
+        return Promise.resolve();
+      }
 
       return StackTrace.fromError(exception).then(
-        (stackFrames: any[]) => this.processError(context, exception, stackFrames),
-        () => {
-          context.cancel = true;
-          return Promise.reject(new Error('Unable to parse the exceptions stack trace. This exception will be discarded.'))
-      });
+        (stackFrames: StackTrace.StackFrame[]) => this.processError(context, exception, stackFrames),
+        () => this.onParseError(context)
+      );
     }
 
-    private processError(context:Exceptionless.EventPluginContext, exception:Error, stackFrames: StackTrace.StackFrame[]) {
+    private processError(context:Exceptionless.EventPluginContext, exception:Error, stackFrames: StackTrace.StackFrame[]): Promise<any> {
       var error:IError = {
         message: exception.message,
         stack_trace: this.getStackFrames(context, stackFrames || []),
-        modules: this.getModules(context)
       };
 
       context.event.data['@error'] = error;
+
+      return Promise.resolve();
+    }
+
+    private onParseError(context:Exceptionless.EventPluginContext): Promise<any>  {
+      context.cancel = true;
+      return Promise.reject(new Error('Unable to parse the exceptions stack trace. This exception will be discarded.'))
     }
 
     private getStackFrames(context:Exceptionless.EventPluginContext, stackFrames:StackTrace.StackFrame[]): IStackFrame[] {
@@ -995,11 +1035,6 @@ module Exceptionless {
 
       return frames;
     }
-
-    private getModules(context:Exceptionless.EventPluginContext): IModule[] {
-      // TODO Get a list of all loaded scripts.
-      return [];
-    }
   }
 
   interface IParameter {

src/gulpfile.js

@@ -27,7 +27,7 @@ gulp.task('scripts', function() {
 
   return eventStream.merge(
     tsResult.dts.pipe(gulp.dest('dist')),
-    tsResult.js.pipe(sourcemaps.write())
+    tsResult.js.pipe(sourcemaps.write('/'))
                .pipe(gulp.dest('dist'))
   );
 });

src/index.html

@@ -25,6 +25,7 @@
     "gulp-sourcemaps": "^1.5.1",
     "gulp-typescript": "^2.6.0",
     "gulp-util": "~3.0.4",
+    "jasmine-core": "^2.2.0",
     "karma": "~0.12.31",
     "karma-chrome-launcher": "^0.1.7",
     "karma-cli": "0.0.4",