Merge pull request webpack#7498 from webpack/bugfix/hmr-parent-import

add parents correctly when creating namespace objects

Author: sokra

lib/HotModuleReplacement.runtime.js

@@ -55,7 +55,8 @@ module.exports = function() {
 		for (var name in $require$) {
 			if (
 				Object.prototype.hasOwnProperty.call($require$, name) &&
-				name !== "e"
+				name !== "e" &&
+				name !== "t"
 			) {
 				Object.defineProperty(fn, name, ObjectFactory(name));
 			}
@@ -80,6 +81,10 @@ module.exports = function() {
 				}
 			}
 		};
+		fn.t = function(value, mode) {
+			if (mode & 1) value = fn(value);
+			return $require$.t(value, mode & ~1);
+		};
 		return fn;
 	}
 

test/hotCases/runtime/bubble-async/file.js

@@ -0,0 +1,3 @@
+module.exports = 1;
+---
+module.exports = 2;

test/hotCases/runtime/bubble-async/index.js

@@ -0,0 +1,16 @@
+import { load } from "./parent-file";
+import update from "../../update";
+
+it("should bubble update from a nested dependency", () => {
+	return load().then(value => {
+		expect(value).toBe(1);
+		return new Promise((resolve, reject) => {
+			module.hot.accept("./parent-file", () => {
+				resolve(load().then(value => {
+					expect(value).toBe(2);
+				}));
+			});
+			NEXT(update(reject));
+		});
+	})
+});

test/hotCases/runtime/bubble-async/parent-file.js

@@ -0,0 +1,3 @@
+export function load() {
+	return import("./file").then(file => file.default);
+}