Skip to content

Commit 54977cd

Browse files
byzykbyzyk
committed
fix benchmark linter issues
1 parent 10b3aa7 commit 54977cd

File tree

7 files changed

+216
-167
lines changed

7 files changed

+216
-167
lines changed

‎benchmark/benchmark.js‎

Lines changed: 99 additions & 85 deletions
Original file line numberDiff line numberDiff line change
@@ -14,117 +14,118 @@ const benchmarkOptions = {
1414
};
1515

1616
function runTimes(compiler, times, deferred) {
17-
fs.writeFileSync(path.join(fixtures, "0.js"), "module.exports = " + Math.random(), "utf-8");
17+
fs.writeFileSync(
18+
path.join(fixtures, "0.js"),
19+
"module.exports = " + Math.random(),
20+
"utf-8"
21+
);
1822
compiler.run(err => {
19-
if(err) throw err;
20-
if(times === 1)
21-
deferred.resolve();
22-
else
23-
runTimes(compiler, times - 1, deferred);
23+
if (err) throw err;
24+
if (times === 1) deferred.resolve();
25+
else runTimes(compiler, times - 1, deferred);
2426
});
2527
}
2628

2729
const tests = {
2830
"normal build": [
2931
[0, 1, 5, 10, 50, 100, 200],
3032
(size, deferred) => {
31-
webpack({
32-
context: fixtures,
33-
entry: `./${size}.js`,
34-
output: {
35-
path: outputPath,
36-
filename: "bundle.js"
33+
webpack(
34+
{
35+
context: fixtures,
36+
entry: `./${size}.js`,
37+
output: {
38+
path: outputPath,
39+
filename: "bundle.js"
40+
}
41+
},
42+
err => {
43+
if (err) throw err;
44+
deferred.resolve();
3745
}
38-
}, err => {
39-
if(err) throw err;
40-
deferred.resolve();
41-
});
46+
);
4247
}
4348
],
4449
"eval dev build": [
4550
[0, 1, 2, 5, 10, 15],
4651
(size, deferred) => {
47-
webpack({
48-
context: fixtures,
49-
entry: `./${size}.big.js`,
50-
output: {
51-
path: outputPath,
52-
filename: "bundle.js"
52+
webpack(
53+
{
54+
context: fixtures,
55+
entry: `./${size}.big.js`,
56+
output: {
57+
path: outputPath,
58+
filename: "bundle.js"
59+
},
60+
devtool: "eval"
5361
},
54-
devtool: "eval"
55-
}, err => {
56-
if(err) throw err;
57-
deferred.resolve();
58-
});
62+
err => {
63+
if (err) throw err;
64+
deferred.resolve();
65+
}
66+
);
5967
}
6068
],
6169
"sourcemap build": [
6270
[0, 1, 2, 5, 10, 15],
6371
(size, deferred) => {
64-
webpack({
65-
context: fixtures,
66-
entry: `./${size}.big.js`,
67-
output: {
68-
path: outputPath,
69-
filename: "bundle.js"
72+
webpack(
73+
{
74+
context: fixtures,
75+
entry: `./${size}.big.js`,
76+
output: {
77+
path: outputPath,
78+
filename: "bundle.js"
79+
},
80+
devtool: "source-map"
7081
},
71-
devtool: "source-map"
72-
}, err => {
73-
if(err) throw err;
74-
deferred.resolve();
75-
});
82+
err => {
83+
if (err) throw err;
84+
deferred.resolve();
85+
}
86+
);
7687
}
7788
],
7889
"cheap sourcemap build": [
7990
[0, 1, 2, 5, 10, 15],
8091
(size, deferred) => {
81-
webpack({
82-
context: fixtures,
83-
entry: `./${size}.big.js`,
84-
output: {
85-
path: outputPath,
86-
filename: "bundle.js"
92+
webpack(
93+
{
94+
context: fixtures,
95+
entry: `./${size}.big.js`,
96+
output: {
97+
path: outputPath,
98+
filename: "bundle.js"
99+
},
100+
devtool: "cheap-source-map"
87101
},
88-
devtool: "cheap-source-map"
89-
}, err => {
90-
if(err) throw err;
91-
deferred.resolve();
92-
});
93-
}
94-
],
95-
"build w/ chunks": [
96-
[0, 1, 5, 10, 50, 100, 200],
97-
(size, deferred) => {
98-
webpack({
99-
context: fixtures,
100-
entry: `./${size}.async.js`,
101-
output: {
102-
path: outputPath,
103-
filename: "bundle.js"
102+
err => {
103+
if (err) throw err;
104+
deferred.resolve();
104105
}
105-
}, err => {
106-
if(err) throw err;
107-
deferred.resolve();
108-
});
106+
);
109107
}
110108
],
111109
"build w/ chunks": [
112110
[0, 1, 5, 10, 50, 100, 200],
113111
(size, deferred) => {
114-
webpack({
115-
context: fixtures,
116-
entry: "./" + size + ".async.js",
117-
output: {
118-
path: outputPath,
119-
filename: "bundle.js"
112+
webpack(
113+
{
114+
context: fixtures,
115+
entry: `./${size}.async.js`,
116+
output: {
117+
path: outputPath,
118+
filename: "bundle.js"
119+
}
120+
},
121+
err => {
122+
if (err) throw err;
123+
deferred.resolve();
120124
}
121-
}, err => {
122-
if(err) throw err;
123-
deferred.resolve();
124-
});
125+
);
125126
}
126127
],
127-
"incremental": [
128+
incremental: [
128129
[0, 1, 5, 10, 50, 100, 200],
129130
(size, deferred) => {
130131
var compiler = webpack({
@@ -155,7 +156,7 @@ const tests = {
155156
runTimes(compiler, size, deferred);
156157
}
157158
],
158-
"incremental2": [
159+
incremental2: [
159160
[0, 1, 5, 10, 50, 100, 200],
160161
(size, deferred) => {
161162
var compiler = webpack({
@@ -170,7 +171,7 @@ const tests = {
170171
runTimes(compiler, 3, deferred);
171172
}
172173
],
173-
"incremental4": [
174+
incremental4: [
174175
[0, 1, 5, 10, 50, 100, 200],
175176
(size, deferred) => {
176177
var compiler = webpack({
@@ -185,7 +186,7 @@ const tests = {
185186
runTimes(compiler, 5, deferred);
186187
}
187188
],
188-
"incremental16": [
189+
incremental16: [
189190
[0, 1, 5, 10, 50, 100, 200],
190191
(size, deferred) => {
191192
var compiler = webpack({
@@ -199,25 +200,38 @@ const tests = {
199200
});
200201
runTimes(compiler, 17, deferred);
201202
}
202-
],
203+
]
203204
};
204205

205-
const suite = new Benchmark.Suite;
206+
const suite = new Benchmark.Suite();
206207

207-
Object.keys(tests).filter(name => process.argv.length > 2 ? name.includes(process.argv[2]) : true)
208+
Object.keys(tests)
209+
.filter(
210+
name => (process.argv.length > 2 ? name.includes(process.argv[2]) : true)
211+
)
208212
.forEach(name => {
209213
const test = tests[name];
210214
test[0].forEach(size => {
211-
suite.add(`${name} ${size}`, deferred => {
212-
test[1](size, deferred);
213-
}, benchmarkOptions);
215+
suite.add(
216+
`${name} ${size}`,
217+
deferred => {
218+
test[1](size, deferred);
219+
},
220+
benchmarkOptions
221+
);
214222
});
215223
});
216224

217225
suite.on("cycle", event => {
218226
process.stderr.write("\n");
219227
const b = event.target;
220-
console.log(b.name + "\t" + Math.floor(1000 * (b.stats.mean - b.stats.moe)) + "\t" + Math.floor(1000 * (b.stats.mean + b.stats.moe)));
228+
console.log(
229+
b.name +
230+
"\t" +
231+
Math.floor(1000 * (b.stats.mean - b.stats.moe)) +
232+
"\t" +
233+
Math.floor(1000 * (b.stats.mean + b.stats.moe))
234+
);
221235
});
222236

223237
suite.run({

‎benchmark/createBenchmark.js‎

Lines changed: 25 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,29 @@
1+
// eslint-disable-next-line node/no-extraneous-require
12
const webpack = require("webpack");
23
const path = require("path");
34

4-
webpack({
5-
context: __dirname,
6-
entry: "./createBenchmark/entry.js",
7-
output: {
8-
path: __dirname,
9-
filename: "benchmark-bundle.js"
5+
webpack(
6+
{
7+
context: __dirname,
8+
entry: "./createBenchmark/entry.js",
9+
output: {
10+
path: __dirname,
11+
filename: "benchmark-bundle.js"
12+
},
13+
target: "node",
14+
node: {
15+
__dirname: false
16+
},
17+
plugins: [
18+
new webpack.NamedModulesPlugin(),
19+
new webpack.IgnorePlugin(/^(fsevents|uglify-js)$/),
20+
new webpack.NormalModuleReplacementPlugin(
21+
/^.\/loadLoader$/,
22+
path.resolve(__dirname, "./createBenchmark/loadLoader")
23+
)
24+
]
1025
},
11-
target: "node",
12-
node: {
13-
__dirname: false
14-
},
15-
plugins: [
16-
new webpack.NamedModulesPlugin(),
17-
new webpack.IgnorePlugin(/^(fsevents|uglify-js)$/),
18-
new webpack.NormalModuleReplacementPlugin(/^.\/loadLoader$/, path.resolve(__dirname, "./createBenchmark/loadLoader"))
19-
]
20-
}, (err, stats) => {
21-
console.log(stats.toString());
22-
});
26+
(err, stats) => {
27+
console.log(stats.toString());
28+
}
29+
);

‎benchmark/createBenchmark/entry.js‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
// eslint-disable-next-line node/no-extraneous-require
12
const webpack = require("webpack");
2-
const MemoryFs = require("memory-fs");
33
const path = require("path");
44

55
const testCase = process.argv[2];
@@ -15,11 +15,13 @@ const config = {
1515

1616
const compiler = webpack(config);
1717
compiler.run((err, stats) => {
18-
if(err) {
18+
if (err) {
1919
console.error(err);
2020
} else {
21-
console.log(stats.toString({
22-
errorDetails: true
23-
}));
21+
console.log(
22+
stats.toString({
23+
errorDetails: true
24+
})
25+
);
2426
}
2527
});

‎benchmark/createBenchmark/loadLoader.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
module.exports = (loader, callback) => {
22
callback(new Error("Loaders are not supported"));
3-
}
3+
};

0 commit comments

Comments
 (0)