hot.accept parser stops traversing based on number of args

Author: Justin Helmer

lib/HotModuleReplacementPlugin.js

@@ -215,10 +215,13 @@ module.exports = class HotModuleReplacementPlugin {
 								this.state.module.addDependency(dep);
 								requests.push(request);
 							});
-							if(expr.arguments.length > 1)
+							if(expr.arguments.length > 1) {
 								this.applyPluginsBailResult("hot accept callback", expr.arguments[1], requests);
-							else
+								parser.walkExpression(expr.arguments[1]); // other args are ignored
+							} else {
 								this.applyPluginsBailResult("hot accept without callback", expr, requests);
+							}
+							return true;
 						}
 					}
 				});

test/hotCases/define/issue-7083/a.js

@@ -0,0 +1,3 @@
+export default 1;
+---
+export default 2;

test/hotCases/define/issue-7083/index.js

@@ -0,0 +1 @@
+import "./module";

test/hotCases/define/issue-7083/module.js

@@ -0,0 +1,19 @@
+import value1 from "./a";
+
+it("should have the expected static path defined", function() {
+	DEFINE_PATH.should.be.eql('./a');
+});
+
+it("should hot.accept the module located at the static file path without breaking the compiler", function() {
+	module.hot.accept("./a");
+	value1.should.be.eql(1);
+});
+
+it("should hot.accept the module located at the defined file path without breaking the compiler, when one argument is passed to hot.accept", function() {
+	module.hot.accept(DEFINE_PATH);
+});
+
+it("should hot.accept the module located at the defined file path without breaking the compiler, when multiple arguments are passed to hot.accept", function(done) {
+	module.hot.accept(DEFINE_PATH, () => done());
+	NEXT(require("../../update")(done));
+});

test/hotCases/define/issue-7083/webpack.config.js

@@ -0,0 +1,11 @@
+"use strict";
+
+const webpack = require("../../../../");
+
+module.exports = {
+	plugins: [
+		new webpack.DefinePlugin({
+			DEFINE_PATH: JSON.stringify("./a")
+		})
+	]
+};