Skip to content

Commit c334d08

Browse files
committed
replace minimatch with micromatch
1 parent b620a58 commit c334d08

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

lib/optimize/SideEffectsFlagPlugin.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55
"use strict";
66

7-
const minimatch = require("minimatch");
7+
const mm = require("micromatch");
88
const HarmonyExportImportedSpecifierDependency = require("../dependencies/HarmonyExportImportedSpecifierDependency");
99
const HarmonyImportSideEffectDependency = require("../dependencies/HarmonyImportSideEffectDependency");
1010
const HarmonyImportSpecifierDependency = require("../dependencies/HarmonyImportSpecifierDependency");
@@ -126,7 +126,12 @@ class SideEffectsFlagPlugin {
126126
case "boolean":
127127
return flagValue;
128128
case "string":
129-
return minimatch(moduleName, flagValue);
129+
if(process.platform === "win32") {
130+
flagValue = flagValue.replace(/\\/g, "/");
131+
}
132+
return mm.isMatch(moduleName, flagValue, {
133+
matchBase: true
134+
});
130135
case "object":
131136
return flagValue.some(glob => SideEffectsFlagPlugin.moduleHasSideEffects(moduleName, glob));
132137
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"loader-runner": "^2.3.0",
1616
"loader-utils": "^1.1.0",
1717
"memory-fs": "~0.4.1",
18-
"minimatch": "^3.0.4",
18+
"micromatch": "^3.1.6",
1919
"mkdirp": "~0.5.0",
2020
"neo-async": "^2.5.0",
2121
"node-libs-browser": "^2.0.0",

0 commit comments

Comments
 (0)