Skip to content

Commit 1c2abbc

Browse files
committed
feat: upgrade to clang-format v1.0.19.
This fixes a performance regression with arrow functions, allowing us to re-enable formatting for the specs.
1 parent 7648bb8 commit 1c2abbc

File tree

3 files changed

+98
-100
lines changed

3 files changed

+98
-100
lines changed

gulpfile.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -198,8 +198,7 @@ gulp.task('build/pubbuild.dart', pubbuild(gulp, gulpPlugins, {
198198
// formatting
199199

200200
function doCheckFormat() {
201-
return gulp.src(['modules/**/*.ts', 'tools/**/*.ts', '!**/typings/**/*.d.ts',
202-
'!**/*.spec.ts', '!**/*_spec.ts' /* angular/clang-format#/11 */])
201+
return gulp.src(['modules/**/*.ts', 'tools/**/*.ts', '!**/typings/**/*.d.ts'])
203202
.pipe(format.checkFormat('file'));
204203
}
205204

@@ -790,15 +789,15 @@ gulp.task('bundle.js.sfx.dev', ['build.js.dev'], function() {
790789

791790
gulp.task('bundle.js.prod.deps', ['bundle.js.prod'], function() {
792791
return bundler.modify(
793-
['node_modules/zone.js/dist/zone-microtask.js', 'node_modules/reflect-metadata/Reflect.js',
792+
['node_modules/zone.js/dist/zone-microtask.js', 'node_modules/reflect-metadata/Reflect.js',
794793
'dist/build/angular2.js'],
795794
'angular2.js'
796795
).pipe(gulp.dest('dist/bundle'));
797796
});
798797

799-
gulp.task('bundle.js.min.deps', ['bundle.js.min'], function() {
798+
gulp.task('bundle.js.min.deps', ['bundle.js.min'], function() {
800799
return bundler.modify(
801-
['node_modules/zone.js/dist/zone-microtask.min.js',
800+
['node_modules/zone.js/dist/zone-microtask.min.js',
802801
'node_modules/reflect-metadata/Reflect.js', 'dist/build/angular2.min.js'],
803802
'angular2.min.js'
804803
)

npm-shrinkwrap.clean.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3935,7 +3935,7 @@
39353935
"version": "1.0.19",
39363936
"dependencies": {
39373937
"clang-format": {
3938-
"version": "1.0.17"
3938+
"version": "1.0.19"
39393939
},
39403940
"gulp-util": {
39413941
"version": "3.0.5",

0 commit comments

Comments
 (0)