Skip to content

Commit 4fe9193

Browse files
committed
refactor(forms): made directive names consistent
1 parent a858f6a commit 4fe9193

24 files changed

+150
-162
lines changed

modules/angular2/angular2.api.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ export * from './src/core/compiler/element_injector';
1818
// We export the Directive *annotation* instead of the *decorator*.
1919
// But it breaks the build.
2020
export {Directive, LifecycleEvent} from './src/core/annotations_impl/annotations';
21-
export {FormDirective} from './src/forms/directives/form_directive';
22-
export {ControlContainerDirective} from './src/forms/directives/control_container_directive';
21+
export {Form} from './src/forms/directives/form_interface';
22+
export {ControlContainer} from './src/forms/directives/control_container';
2323
export {Injectable} from './src/di/annotations_impl';
2424
export {BaseQueryList} from './src/core/compiler/base_query_list';
2525
export {AppProtoView, AppView, AppViewContainer} from './src/core/compiler/view';

modules/angular2/forms.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
export * from './src/forms/model';
1717
export * from './src/forms/directives';
1818
export * from './src/forms/validators';
19-
export * from './src/forms/validator_directives';
19+
export * from './src/forms/directives/validators';
2020
export * from './src/forms/form_builder';
2121

2222
import {FormBuilder} from './src/forms/form_builder';
Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,27 @@
11
import {Type, CONST_EXPR} from 'angular2/src/facade/lang';
2-
import {ControlNameDirective} from './directives/control_name_directive';
3-
import {FormControlDirective} from './directives/form_control_directive';
4-
import {NgModelDirective} from './directives/ng_model_directive';
5-
import {ControlGroupDirective} from './directives/control_group_directive';
6-
import {FormModelDirective} from './directives/form_model_directive';
7-
import {TemplateDrivenFormDirective} from './directives/template_driven_form_directive';
2+
import {NgControlName} from './directives/ng_control_name';
3+
import {NgFormControl} from './directives/ng_form_control';
4+
import {NgModel} from './directives/ng_model';
5+
import {NgControlGroup} from './directives/ng_control_group';
6+
import {NgFormModel} from './directives/ng_form_model';
7+
import {NgForm} from './directives/ng_form';
88
import {DefaultValueAccessor} from './directives/default_value_accessor';
99
import {CheckboxControlValueAccessor} from './directives/checkbox_value_accessor';
1010
import {SelectControlValueAccessor} from './directives/select_control_value_accessor';
11-
import {RequiredValidatorDirective} from './validator_directives';
11+
import {NgRequiredValidator} from './directives/validators';
1212

13-
export {ControlNameDirective} from './directives/control_name_directive';
14-
export {FormControlDirective} from './directives/form_control_directive';
15-
export {NgModelDirective} from './directives/ng_model_directive';
16-
export {ControlDirective} from './directives/control_directive';
17-
export {ControlGroupDirective} from './directives/control_group_directive';
18-
export {FormModelDirective} from './directives/form_model_directive';
19-
export {TemplateDrivenFormDirective} from './directives/template_driven_form_directive';
13+
export {NgControlName} from './directives/ng_control_name';
14+
export {NgFormControl} from './directives/ng_form_control';
15+
export {NgModel} from './directives/ng_model';
16+
export {NgControl} from './directives/ng_control';
17+
export {NgControlGroup} from './directives/ng_control_group';
18+
export {NgFormModel} from './directives/ng_form_model';
19+
export {NgForm} from './directives/ng_form';
2020
export {ControlValueAccessor} from './directives/control_value_accessor';
2121
export {DefaultValueAccessor} from './directives/default_value_accessor';
2222
export {CheckboxControlValueAccessor} from './directives/checkbox_value_accessor';
2323
export {SelectControlValueAccessor} from './directives/select_control_value_accessor';
24-
export {RequiredValidatorDirective} from './validator_directives';
24+
export {NgRequiredValidator} from './directives/validators';
2525

2626
/**
2727
*
@@ -32,17 +32,17 @@ export {RequiredValidatorDirective} from './validator_directives';
3232
* @exportedAs angular2/forms
3333
*/
3434
export const formDirectives: List<Type> = CONST_EXPR([
35-
ControlNameDirective,
36-
ControlGroupDirective,
35+
NgControlName,
36+
NgControlGroup,
3737

38-
FormControlDirective,
39-
NgModelDirective,
40-
FormModelDirective,
41-
TemplateDrivenFormDirective,
38+
NgFormControl,
39+
NgModel,
40+
NgFormModel,
41+
NgForm,
4242

4343
DefaultValueAccessor,
4444
CheckboxControlValueAccessor,
4545
SelectControlValueAccessor,
4646

47-
RequiredValidatorDirective
47+
NgRequiredValidator
4848
]);

modules/angular2/src/forms/directives/checkbox_value_accessor.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import {Directive} from 'angular2/angular2';
2-
import {ControlDirective} from './control_directive';
2+
import {NgControl} from './ng_control';
33
import {ControlValueAccessor} from './control_value_accessor';
44

55
/**
@@ -33,7 +33,7 @@ export class CheckboxControlValueAccessor implements ControlValueAccessor {
3333
onChange: Function;
3434
onTouched: Function;
3535

36-
constructor(private cd: ControlDirective) {
36+
constructor(private cd: NgControl) {
3737
this.onChange = (_) => {};
3838
this.onTouched = (_) => {};
3939
cd.valueAccessor = this;
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
import {Form} from './form_interface';
2+
import {List} from 'angular2/src/facade/collection';
3+
4+
/**
5+
* A directive that contains a group of [NgControl].
6+
*
7+
* @exportedAs angular2/forms
8+
*/
9+
export class ControlContainer {
10+
name: string;
11+
get formDirective(): Form { return null; }
12+
get path(): List<string> { return null; }
13+
}

modules/angular2/src/forms/directives/control_container_directive.ts

Lines changed: 0 additions & 13 deletions
This file was deleted.

modules/angular2/src/forms/directives/default_value_accessor.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import {Directive} from 'angular2/angular2';
2-
import {ControlDirective} from './control_directive';
2+
import {NgControl} from './ng_control';
33
import {ControlValueAccessor} from './control_value_accessor';
44
import {isBlank} from 'angular2/src/facade/lang';
55

@@ -37,7 +37,7 @@ export class DefaultValueAccessor implements ControlValueAccessor {
3737
onChange: Function;
3838
onTouched: Function;
3939

40-
constructor(private cd: ControlDirective) {
40+
constructor(private cd: NgControl) {
4141
this.onChange = (_) => {};
4242
this.onTouched = (_) => {};
4343
cd.valueAccessor = this;

modules/angular2/src/forms/directives/form_directive.ts

Lines changed: 0 additions & 12 deletions
This file was deleted.
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import {NgControl} from './ng_control';
2+
import {NgControlGroup} from './ng_control_group';
3+
import {Control} from '../model';
4+
5+
export interface Form {
6+
addControl(dir: NgControl): void;
7+
removeControl(dir: NgControl): void;
8+
getControl(dir: NgControl): Control;
9+
addControlGroup(dir: NgControlGroup): void;
10+
removeControlGroup(dir: NgControlGroup): void;
11+
updateModel(dir: NgControl, value: any): void;
12+
}

modules/angular2/src/forms/directives/control_directive.ts renamed to modules/angular2/src/forms/directives/ng_control.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {Control} from '../model';
77
*
88
* @exportedAs angular2/forms
99
*/
10-
export class ControlDirective {
10+
export class NgControl {
1111
name: string = null;
1212
valueAccessor: ControlValueAccessor = null;
1313
validator: Function;

0 commit comments

Comments
 (0)