Skip to content

Commit d1a7616

Browse files
committed
moved join to Diff so subclasses can override it
1 parent 5eb1d28 commit d1a7616

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

src/diff/base.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,9 @@ Diff.prototype = {
160160
},
161161
tokenize(value) {
162162
return value.split('');
163+
},
164+
join(chars) {
165+
return chars.join('');
163166
}
164167
};
165168

@@ -179,9 +182,9 @@ function buildValues(diff, components, newString, oldString, useLongestToken) {
179182
return oldValue.length > value.length ? oldValue : value;
180183
});
181184

182-
component.value = value.join('');
185+
component.value = diff.join(value);
183186
} else {
184-
component.value = newString.slice(newPos, newPos + component.count).join('');
187+
component.value = diff.join(newString.slice(newPos, newPos + component.count));
185188
}
186189
newPos += component.count;
187190

@@ -190,7 +193,7 @@ function buildValues(diff, components, newString, oldString, useLongestToken) {
190193
oldPos += component.count;
191194
}
192195
} else {
193-
component.value = oldString.slice(oldPos, oldPos + component.count).join('');
196+
component.value = diff.join(oldString.slice(oldPos, oldPos + component.count));
194197
oldPos += component.count;
195198

196199
// Reverse add and remove so removes are output first to match common convention

0 commit comments

Comments
 (0)