Use str_starts_with(), str_contains(), or str_ends_with() instead of strpos()

Author: sebastianbergmann

src/Filter.php

@@ -12,7 +12,6 @@
 use function array_keys;
 use function is_file;
 use function realpath;
-use function strpos;
 use SebastianBergmann\FileIterator\Facade as FileIteratorFacade;
 
 final class Filter
@@ -80,14 +79,14 @@ public function isFile(string $filename): bool
         }
 
         if ($filename === '-' ||
-            strpos($filename, 'vfs://') === 0 ||
-            strpos($filename, 'xdebug://debug-eval') !== false ||
-            strpos($filename, 'eval()\'d code') !== false ||
-            strpos($filename, 'runtime-created function') !== false ||
-            strpos($filename, 'runkit created function') !== false ||
-            strpos($filename, 'assert code') !== false ||
-            strpos($filename, 'regexp code') !== false ||
-            strpos($filename, 'Standard input code') !== false) {
+            str_starts_with($filename, 'vfs://') ||
+            str_contains($filename, 'xdebug://debug-eval') ||
+            str_contains($filename, 'eval()\'d code') ||
+            str_contains($filename, 'runtime-created function') ||
+            str_contains($filename, 'runkit created function') ||
+            str_contains($filename, 'assert code') ||
+            str_contains($filename, 'regexp code') ||
+            str_contains($filename, 'Standard input code')) {
             $isFile = false;
         } else {
             $isFile = is_file($filename);

src/Node/AbstractNode.php

@@ -34,7 +34,7 @@ abstract class AbstractNode implements Countable
 
     public function __construct(string $name, self $parent = null)
     {
-        if (substr($name, -1) === DIRECTORY_SEPARATOR) {
+        if (str_ends_with($name, DIRECTORY_SEPARATOR)) {
             $name = substr($name, 0, -1);
         }
 

src/Node/Builder.php

@@ -18,7 +18,6 @@
 use function implode;
 use function is_file;
 use function str_replace;
-use function strpos;
 use function substr;
 use SebastianBergmann\CodeCoverage\CodeCoverage;
 use SebastianBergmann\CodeCoverage\ProcessedCodeCoverageData;
@@ -59,7 +58,7 @@ private function addItems(Directory $root, array $items, array $tests): void
         foreach ($items as $key => $value) {
             $key = (string) $key;
 
-            if (substr($key, -2) === '/f') {
+            if (str_ends_with($key, '/f')) {
                 $key      = substr($key, 0, -2);
                 $filename = $root->pathAsString() . DIRECTORY_SEPARATOR . $key;
 
@@ -211,7 +210,7 @@ private function reducePaths(ProcessedCodeCoverageData $coverage): string
 
         for ($i = 0; $i < $max; $i++) {
             // strip phar:// prefixes
-            if (strpos($paths[$i], 'phar://') === 0) {
+            if (str_starts_with($paths[$i], 'phar://')) {
                 $paths[$i] = substr($paths[$i], 7);
                 $paths[$i] = str_replace('/', DIRECTORY_SEPARATOR, $paths[$i]);
             }

src/Report/Html/Renderer/File.php

@@ -91,7 +91,6 @@
 use function is_string;
 use function sprintf;
 use function str_replace;
-use function substr;
 use function token_get_all;
 use function trim;
 use SebastianBergmann\CodeCoverage\Node\File as FileNode;
@@ -878,7 +877,7 @@ private function loadFile(string $file): array
         $result              = [''];
         $i                   = 0;
         $stringFlag          = false;
-        $fileEndsWithNewLine = substr($buffer, -1) === "\n";
+        $fileEndsWithNewLine = str_ends_with($buffer, "\n");
 
         unset($buffer);
 

src/StaticAnalysis/IgnoredLinesFindingVisitor.php

@@ -11,7 +11,6 @@
 
 use function array_merge;
 use function range;
-use function strpos;
 use PhpParser\Node;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassMethod;
@@ -76,14 +75,14 @@ public function enterNode(Node $node): ?int
             return null;
         }
 
-        if (strpos($docComment->getText(), '@codeCoverageIgnore') !== false) {
+        if (str_contains($docComment->getText(), '@codeCoverageIgnore')) {
             $this->ignoredLines = array_merge(
                 $this->ignoredLines,
                 range($node->getStartLine(), $node->getEndLine())
             );
         }
 
-        if ($this->ignoreDeprecated && strpos($docComment->getText(), '@deprecated') !== false) {
+        if ($this->ignoreDeprecated && str_contains($docComment->getText(), '@deprecated')) {
             $this->ignoredLines = array_merge(
                 $this->ignoredLines,
                 range($node->getStartLine(), $node->getEndLine())