Skip to content

Commit 7dd2f08

Browse files
committed
chore: keep dispose before value for homogeneity
1 parent e793866 commit 7dd2f08

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ await fetch(url, { signal: token });
314314
A disposable is a simple object, which contains a dispose method and possibily a value:
315315

316316
```js
317-
const disposable = { value: db, dispose: () => db.close() };
317+
const disposable = { dispose: () => db.close(), value: db };
318318
```
319319

320320
The dispose method may be asynchronous and return a promise.

src/Disposable.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
const Disposable = require("./Disposable");
44
const { reject } = require("./fixtures");
55

6-
const d = () => ({ value: Math.random(), dispose: jest.fn() });
6+
const d = () => ({ dispose: jest.fn(), value: Math.random() });
77

88
describe("Disposable", () => {
99
it("cannot be used after being disposed of", async () => {
10-
const { value, dispose } = d();
10+
const { dispose, value } = d();
1111
const disposable = new Disposable(dispose, value);
1212

1313
expect(disposable.value).toBe(value);

src/_ExitStack.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ module.exports = class ExitStack {
1212
? resolve(disposable.dispose()).then(dispose)
1313
: Promise.resolve();
1414
};
15-
return { value: this, dispose };
15+
return { dispose, value: this };
1616
}
1717

1818
enter(disposable) {

0 commit comments

Comments
 (0)