Deprecate matchall

[nalimilan]

It is not obvious that returning matching SubStrings rather than RegexMatch objects is a good idea.

Fixes #26049.

[nalimilan]

I hope this change is correct. AFAICT it is, but the original code is such a convoluted way of doing this that I feel like I may be missing something.

[mbauman]

Looks right to me, too. Could be equalto(' ').

[nalimilan]

Yeah, I realized that right after pushing. Fixed while rebasing.

[nalimilan]

I'll merge once CI passes barring objections.

[mbauman]

You've got an old f() call in here.

[nalimilan]

Thanks, fixed!

[diam]

Ruby has a scan String method for the julia old matchall expected behavior.
https://ruby-doc.org/core-2.4.0/String.html#method-i-scan

Is it too late to add (or reserve) this name for julia-07?

words = collect(m.match for m in eachmatch(r"\d+(\.\d+)?", txt))

I'd much more prefer:

words = scan(r"\d+(\.\d+)?", txt)

-- Maurice

[StefanKarpinski]

There's no need to reserve names: exporting new names from Base is not considered breaking.

[diam]

Bonjour,

This post is moved to discourse:
see https://discourse.julialang.org/t/best-way-to-get-all-substrings-or-numbers-matching-a-regex/31571

So what is the best way from julia-1.3+ for getting a String Vector from a regex like with matchall?

# findall?
...
# eachmatch?
...

-- Maurice

[KristofferC]

Instead of commenting on old issues, it is better to open a new thread at https://discourse.julialang.org/ for questions.

[kubark42]

Instead of commenting on old issues, it is better to open a new thread at https://discourse.julialang.org/ for questions.

I'd like to lightly disagree with this statement. I found this issue by using the changelog. I was looking for why matchall() no longer worked, and to understand what its replacement was. Without @diam's question and subsequent link, I would never have found the discourse page.

Of course, the true value is the cross-link to the discourse page, but since that doesn't happen automatically it's valuable to see discourse open here before ultimately moving to a better home.