Fix NPE when re-scheduling read timeouts, close AsyncHttpClient#773

Author: Stephane Landelle

providers/netty3/src/main/java/org/asynchttpclient/providers/netty3/request/timeout/ReadTimeoutTimerTask.java

@@ -66,8 +66,5 @@ public void run(Timeout timeout) throws Exception {
             // otherwise, no need to reschedule: requestTimeout will happen sooner
             timeoutsHolder.readTimeout = null;
         }
-
-        // this task should be evacuated from the timer but who knows
-        nettyResponseFuture = null;
     }
 }

providers/netty3/src/main/java/org/asynchttpclient/providers/netty3/request/timeout/RequestTimeoutTimerTask.java

@@ -45,8 +45,5 @@ public void run(Timeout timeout) throws Exception {
         String message = "Request timed out to " + remoteAddress + " of " + requestTimeout + " ms";
         long age = millisTime() - nettyResponseFuture.getStart();
         expire(message, age);
-        
-        // this task should be evacuated from the timer but who knows
-        nettyResponseFuture = null;
     }
 }

providers/netty4/src/main/java/org/asynchttpclient/providers/netty4/request/timeout/ReadTimeoutTimerTask.java

@@ -67,8 +67,5 @@ public void run(Timeout timeout) throws Exception {
             // otherwise, no need to reschedule: requestTimeout will happen sooner
             timeoutsHolder.readTimeout = null;
         }
-
-        // this task should be evacuated from the timer but who knows
-        nettyResponseFuture = null;
     }
 }

providers/netty4/src/main/java/org/asynchttpclient/providers/netty4/request/timeout/RequestTimeoutTimerTask.java

@@ -46,8 +46,5 @@ public void run(Timeout timeout) throws Exception {
         String message = "Request timed out to " + remoteAddress + " of " + requestTimeout + " ms";
         long age = millisTime() - nettyResponseFuture.getStart();
         expire(message, age);
-        
-        // this task should be evacuated from the timer but who knows
-        nettyResponseFuture = null;
     }
 }