minor clean up

Author: Stephane Landelle

api/src/main/java/org/asynchttpclient/util/AsyncHttpProviderUtils.java

@@ -31,9 +31,10 @@
 public class AsyncHttpProviderUtils {
 
     public static final IOException REMOTELY_CLOSED_EXCEPTION = new IOException("Remotely closed");
-
+    public static final IOException CHANNEL_CLOSED_EXCEPTION = new IOException("Channel closed");
     static {
-        REMOTELY_CLOSED_EXCEPTION.setStackTrace(new StackTraceElement[] {});
+        REMOTELY_CLOSED_EXCEPTION.setStackTrace(new StackTraceElement[0]);
+        CHANNEL_CLOSED_EXCEPTION.setStackTrace(new StackTraceElement[0]);
     }
 
     private final static byte[] NO_BYTES = new byte[0];

providers/netty3/src/main/java/org/asynchttpclient/providers/netty3/handler/Processor.java

@@ -40,11 +40,6 @@ public class Processor extends SimpleChannelUpstreamHandler {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(Processor.class);
 
-    public static final IOException CHANNEL_CLOSED_EXCEPTION = new IOException("Channel closed");
-    static {
-        CHANNEL_CLOSED_EXCEPTION.setStackTrace(new StackTraceElement[0]);
-    }
-
     private final AsyncHttpClientConfig config;
     private final ChannelManager channelManager;
     private final NettyRequestSender requestSender;
@@ -123,7 +118,7 @@ public void channelClosed(ChannelHandlerContext ctx, ChannelStateEvent e) throws
             future.touch();
 
             if (!config.getIOExceptionFilters().isEmpty()
-                    && requestSender.applyIoExceptionFiltersAndReplayRequest(future, CHANNEL_CLOSED_EXCEPTION, channel))
+                    && requestSender.applyIoExceptionFiltersAndReplayRequest(future, AsyncHttpProviderUtils.CHANNEL_CLOSED_EXCEPTION, channel))
                 return;
 
             protocol.onClose(future);
@@ -159,7 +154,7 @@ public void exceptionCaught(ChannelHandlerContext ctx, ExceptionEvent e) throws
 
                     // FIXME why drop the original exception and throw a new one?
                     if (!config.getIOExceptionFilters().isEmpty()) {
-                        if (!requestSender.applyIoExceptionFiltersAndReplayRequest(future, CHANNEL_CLOSED_EXCEPTION, channel))
+                        if (!requestSender.applyIoExceptionFiltersAndReplayRequest(future, AsyncHttpProviderUtils.CHANNEL_CLOSED_EXCEPTION, channel))
                             // Close the channel so the recovering can occurs.
                             Channels.silentlyCloseChannel(channel);
                         return;

providers/netty4/src/main/java/org/asynchttpclient/providers/netty4/handler/Processor.java

@@ -13,7 +13,8 @@
  */
 package org.asynchttpclient.providers.netty4.handler;
 
-import static org.asynchttpclient.util.AsyncHttpProviderUtils.REMOTELY_CLOSED_EXCEPTION;
+import static org.asynchttpclient.util.AsyncHttpProviderUtils.*;
+
 import io.netty.channel.Channel;
 import io.netty.channel.ChannelHandler.Sharable;
 import io.netty.channel.ChannelHandlerContext;
@@ -40,11 +41,6 @@ public class Processor extends ChannelInboundHandlerAdapter {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(Processor.class);
 
-    public static final IOException CHANNEL_CLOSED_EXCEPTION = new IOException("Channel Closed");
-    static {
-        CHANNEL_CLOSED_EXCEPTION.setStackTrace(new StackTraceElement[0]);
-    }
-
     private final AsyncHttpClientConfig config;
     private final ChannelManager channelManager;
     private final NettyRequestSender requestSender;