From 2066f3024a867ae53c6316db513ac315051e0588 Mon Sep 17 00:00:00 2001 From: Oskar Wallgren Date: Sun, 27 May 2018 15:29:34 +0200 Subject: [PATCH 1/3] FX autoquit disabled by default Really short notes doesn't work well with delay based effects with the default decay settings of the FX autoquit system. --- src/gui/SetupDialog.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gui/SetupDialog.cpp b/src/gui/SetupDialog.cpp index 5063761e256..e07a60d42a9 100644 --- a/src/gui/SetupDialog.cpp +++ b/src/gui/SetupDialog.cpp @@ -135,7 +135,7 @@ SetupDialog::SetupDialog( ConfigTabs _tab_to_open ) : m_displayWaveform(ConfigManager::inst()->value( "ui", "displaywaveform").toInt() ), m_disableAutoQuit(ConfigManager::inst()->value( "ui", - "disableautoquit").toInt() ), + "disableautoquit", "1" ).toInt() ), m_vstEmbedMethod( ConfigManager::inst()->vstEmbedMethod() ) { setWindowIcon( embed::getIconPixmap( "setup_general" ) ); From 003ba50fb71bf409c82488ea8451ff79a03138d0 Mon Sep 17 00:00:00 2001 From: Oskar Wallgren Date: Sun, 27 May 2018 20:07:20 +0200 Subject: [PATCH 2/3] Disable 'Decay' when FX autoquit is disabled --- src/gui/widgets/EffectView.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gui/widgets/EffectView.cpp b/src/gui/widgets/EffectView.cpp index 0a5e46b3ffa..dfd393120c7 100644 --- a/src/gui/widgets/EffectView.cpp +++ b/src/gui/widgets/EffectView.cpp @@ -74,7 +74,7 @@ EffectView::EffectView( Effect * _model, QWidget * _parent ) : m_autoQuit = new TempoSyncKnob( knobBright_26, this ); m_autoQuit->setLabel( tr( "DECAY" ) ); m_autoQuit->move( 60, 5 ); - m_autoQuit->setEnabled( isEnabled ); + m_autoQuit->setEnabled( isEnabled && !effect()->m_autoQuitDisabled ); m_autoQuit->setHintText( tr( "Time:" ), "ms" ); m_autoQuit->setWhatsThis( tr( "The Decay knob controls how many buffers of silence must pass before the " From ea14eac551752d81c0fbb0f914d7292a13f5f983 Mon Sep 17 00:00:00 2001 From: Oskar Wallgren Date: Mon, 28 May 2018 18:16:55 +0200 Subject: [PATCH 3/3] Disable 'Gate' when FX autoquit is disabled --- src/gui/widgets/EffectView.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gui/widgets/EffectView.cpp b/src/gui/widgets/EffectView.cpp index dfd393120c7..29777888d95 100644 --- a/src/gui/widgets/EffectView.cpp +++ b/src/gui/widgets/EffectView.cpp @@ -85,7 +85,7 @@ EffectView::EffectView( Effect * _model, QWidget * _parent ) : m_gate = new Knob( knobBright_26, this ); m_gate->setLabel( tr( "GATE" ) ); m_gate->move( 93, 5 ); - m_gate->setEnabled( isEnabled ); + m_gate->setEnabled( isEnabled && !effect()->m_autoQuitDisabled ); m_gate->setHintText( tr( "Gate:" ), "" ); m_gate->setWhatsThis( tr( "The Gate knob controls the signal level that is considered to be 'silence' "