Skip to content

Add a manual resync button#8

Closed
bdunderscore wants to merge 2 commits into
MerlinVR:masterfrom
bdunderscore:resync
Closed

Add a manual resync button#8
bdunderscore wants to merge 2 commits into
MerlinVR:masterfrom
bdunderscore:resync

Conversation

@bdunderscore
Copy link
Copy Markdown

In some cases currently, it can be necessary to restart the video playback, either because a playback error occurred, or in weirder cases when things like youtube-dl failing to get the audio part of a livestream happens. This PR adds a button which stops and restarts playback in these cases.

This is now required for VRCSDK3 to compile.
@isjame
Copy link
Copy Markdown

isjame commented Nov 17, 2020

GOOD,I have tested it and it works, but for some unknown reason,
this sync button triggers a BUG that causes the entire player UI to failure.

(Test:Just click the Sync button without pressing any other buttons).

This BUG is also common in the world of PYPYDANCE. I think there should be a code to hide the sync button, like PYPYDANCE, Once the video is invalidated or wrong it will Tips on the screen "please click on the sync button", and then the sync button will be displayed.

@MerlinVR MerlinVR mentioned this pull request Jun 12, 2021
Merged
@MerlinVR
Copy link
Copy Markdown
Owner

This has been added in 1.0 as part of #19

@MerlinVR MerlinVR closed this Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants