From 1b5d7a132446d47b8daf8529e7d7e1fe20d83c4e Mon Sep 17 00:00:00 2001 From: Erik Marks <25517051+rekmarks@users.noreply.github.com> Date: Wed, 29 Jul 2020 12:06:18 -0700 Subject: [PATCH 1/3] Correctly characterize async/await changes in changelog (#62) * correctly characterize async/await changes in changelog --- merged-packages/json-rpc-engine/CHANGELOG.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/merged-packages/json-rpc-engine/CHANGELOG.md b/merged-packages/json-rpc-engine/CHANGELOG.md index 253c8a665a5..9c024d4ce8c 100644 --- a/merged-packages/json-rpc-engine/CHANGELOG.md +++ b/merged-packages/json-rpc-engine/CHANGELOG.md @@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed - Remove `async` and `promise-to-callback` dependencies - - These dependencies were used internally for asynchronous control flow. - They have been replaced with Promises and native `async`/`await`. - This has made middleware execution faster, and may affect consumers that rely on middleware timing, advertently or not. + - These dependencies were used internally for middleware flow control. + They have been replaced with Promises and native `async`/`await`, which means that some operations are _no longer_ eagerly executed. + This change may affect consumers that depend on the eager execution of middleware _during_ middleware execution, _outside of_ middleware functions and request handlers. + - In general, it is a bad practice to work with state that depends on middleware execution, while the middleware are executing. From e6839bfb12eadd505cde3bfa3d67c47144481f6e Mon Sep 17 00:00:00 2001 From: Erik Marks <25517051+rekmarks@users.noreply.github.com> Date: Thu, 30 Jul 2020 12:43:03 -0700 Subject: [PATCH 2/3] eth-rpc-errors@3.0.0 (#63) --- merged-packages/json-rpc-engine/package.json | 2 +- merged-packages/json-rpc-engine/yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/merged-packages/json-rpc-engine/package.json b/merged-packages/json-rpc-engine/package.json index 697ea0411e4..2cb936fdae5 100644 --- a/merged-packages/json-rpc-engine/package.json +++ b/merged-packages/json-rpc-engine/package.json @@ -16,7 +16,7 @@ "coverage": "nyc --check-coverage yarn test" }, "dependencies": { - "eth-rpc-errors": "^2.1.1", + "eth-rpc-errors": "^3.0.0", "safe-event-emitter": "^1.0.1" }, "devDependencies": { diff --git a/merged-packages/json-rpc-engine/yarn.lock b/merged-packages/json-rpc-engine/yarn.lock index be4de996eff..f04fd599099 100644 --- a/merged-packages/json-rpc-engine/yarn.lock +++ b/merged-packages/json-rpc-engine/yarn.lock @@ -806,10 +806,10 @@ esutils@^2.0.2: resolved "https://registry.yarnpkg.com/esutils/-/esutils-2.0.2.tgz#0abf4f1caa5bcb1f7a9d8acc6dea4faaa04bac9b" integrity sha1-Cr9PHKpbyx96nYrMbepPqqBLrJs= -eth-rpc-errors@^2.1.1: - version "2.1.1" - resolved "https://registry.yarnpkg.com/eth-rpc-errors/-/eth-rpc-errors-2.1.1.tgz#00a7d6c8a9c864a8ab7d0356be20964e5bee4b13" - integrity sha512-MY3zAa5ZF8hvgQu1HOF9agaK5GgigBRGpTJ8H0oVlE0NqMu13CW6syyjLXdeIDCGQTbUeHliU1z9dVmvMKx1Tg== +eth-rpc-errors@^3.0.0: + version "3.0.0" + resolved "https://registry.yarnpkg.com/eth-rpc-errors/-/eth-rpc-errors-3.0.0.tgz#d7b22653c70dbf9defd4ef490fd08fe70608ca10" + integrity sha512-iPPNHPrLwUlR9xCSYm7HHQjWBasor3+KZfRvwEWxMz3ca0yqnlBeJrnyphkGIXZ4J7AMAaOLmwy4AWhnxOiLxg== dependencies: fast-safe-stringify "^2.0.6" From b647309709ddda0850f54a420a3173cf6217de71 Mon Sep 17 00:00:00 2001 From: Erik Marks <25517051+rekmarks@users.noreply.github.com> Date: Thu, 30 Jul 2020 13:01:28 -0700 Subject: [PATCH 3/3] 5.3.0 (#64) * 5.3.0 * update changelog --- merged-packages/json-rpc-engine/CHANGELOG.md | 6 ++++++ merged-packages/json-rpc-engine/package.json | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/merged-packages/json-rpc-engine/CHANGELOG.md b/merged-packages/json-rpc-engine/CHANGELOG.md index 9c024d4ce8c..31b39c9a0fb 100644 --- a/merged-packages/json-rpc-engine/CHANGELOG.md +++ b/merged-packages/json-rpc-engine/CHANGELOG.md @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +## [5.3.0] - 2020-07-30 + +### Changed + +- Response object errors no longer include a `stack` property + ## [5.2.0] - 2020-07-24 ### Added diff --git a/merged-packages/json-rpc-engine/package.json b/merged-packages/json-rpc-engine/package.json index 2cb936fdae5..5324ceea688 100644 --- a/merged-packages/json-rpc-engine/package.json +++ b/merged-packages/json-rpc-engine/package.json @@ -1,6 +1,6 @@ { "name": "json-rpc-engine", - "version": "5.2.0", + "version": "5.3.0", "description": "a tool for processing JSON RPC", "license": "ISC", "author": "kumavis",