chore: Disable redudant lint rule (#425)

The rule `promise/valid-params` is now disabled in our TypeScript
config. The rule is redundant in a TypeScript context, where Promise
parameters are being type-checked already.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Disables the `promise/valid-params` rule in the TypeScript config and
documents it in the changelog, updating the rules snapshot.
> 
> - **TypeScript ESLint config**
> - Disable `promise/valid-params` in
`packages/typescript/src/index.mjs` (redundant with TS type-checking).
> - **Changelog**
> - Add Unreleased note about disabling `promise/valid-params` in
`packages/typescript/CHANGELOG.md`.
> - **Rules snapshot**
> - Update `packages/typescript/rules-snapshot.json` to include
`"promise/valid-params": "off"`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
0ed1ba2. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: Gudahtt

packages/typescript/CHANGELOG.md

@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - This version has a matching supported `typescript` range, and includes some bug fixes for problems we ran into.
 - Disable `@typescript-eslint/no-unnecessary-type-arguments` ([#426](https://github.com/MetaMask/eslint-config/pull/426))
   - We decided that "unnecessary" type arguments make types easier to read sometimes, so we should allow them.
+- Disable `promise/valid-params` because it's redundant in type-checked projects ([#425](https://github.com/MetaMask/eslint-config/pull/425))
 
 ## [14.1.0]
 

packages/typescript/rules-snapshot.json

@@ -250,5 +250,6 @@
   "prefer-promise-reject-errors": "off",
   "prefer-rest-params": "error",
   "prefer-spread": "error",
+  "promise/valid-params": "off",
   "require-await": "off"
 }

packages/typescript/src/index.mjs

@@ -232,6 +232,11 @@ const config = createConfig({
         message: 'Use a hash name instead.',
       },
     ],
+
+    /* promise plugin rules */
+
+    // TypeScript already validates Promise params, no need to validate them twice
+    'promise/valid-params': 'off',
   },
 });