From 7473fdc2a3c5fc13409afba15f8a092703f68e37 Mon Sep 17 00:00:00 2001 From: Mark Stacey Date: Tue, 2 Dec 2025 12:57:21 -0330 Subject: [PATCH 1/2] chore: Disable redudant lint rule The rule `promise/valid-params` is now disabled in our TypeScript config. The rule is redundant in a TypeScript context, where Promise parameters are being type-checked already. --- packages/typescript/rules-snapshot.json | 1 + packages/typescript/src/index.mjs | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/packages/typescript/rules-snapshot.json b/packages/typescript/rules-snapshot.json index f81cc06..139b899 100644 --- a/packages/typescript/rules-snapshot.json +++ b/packages/typescript/rules-snapshot.json @@ -250,5 +250,6 @@ "prefer-promise-reject-errors": "off", "prefer-rest-params": "error", "prefer-spread": "error", + "promise/valid-params": "off", "require-await": "off" } diff --git a/packages/typescript/src/index.mjs b/packages/typescript/src/index.mjs index afa1e94..035f8c2 100644 --- a/packages/typescript/src/index.mjs +++ b/packages/typescript/src/index.mjs @@ -232,6 +232,11 @@ const config = createConfig({ message: 'Use a hash name instead.', }, ], + + /* promise plugin rules */ + + // TypeScript already validates Promise params, no need to validate them twice + 'promise/valid-params': 'off', }, }); From 0ed1ba275cf86841adb077b0cbde57753070a1eb Mon Sep 17 00:00:00 2001 From: Mark Stacey Date: Tue, 2 Dec 2025 12:59:32 -0330 Subject: [PATCH 2/2] Update changelog --- packages/typescript/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/typescript/CHANGELOG.md b/packages/typescript/CHANGELOG.md index eea7356..f3b279b 100644 --- a/packages/typescript/CHANGELOG.md +++ b/packages/typescript/CHANGELOG.md @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - This version has a matching supported `typescript` range, and includes some bug fixes for problems we ran into. - Disable `@typescript-eslint/no-unnecessary-type-arguments` ([#426](https://github.com/MetaMask/eslint-config/pull/426)) - We decided that "unnecessary" type arguments make types easier to read sometimes, so we should allow them. +- Disable `promise/valid-params` because it's redundant in type-checked projects ([#425](https://github.com/MetaMask/eslint-config/pull/425)) ## [14.1.0]